merge branches and enhance with configurable view filtering #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not continue where you left off
Added functionality to handle when columns have been dropped to drop and re-run the view
…views and run them again so we're dealing with missing relations/views at that point and have a name
* kind of nice when reloading views during CI testing;-)
|
@stevo hi, any chance of getting this P/R reviewed and merged? We're using this in production now, be nice to have various contributions merged back into a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
activerecord-database-viewsis pretty much exactly the view support we needed (of the many options out there).This P/R merges updates from nathanpalmer with master (in particular some basic tests), and adds: