Fix deserializatoin for nested objects (#56)

stfalcon-studio · Mar 14, 2024 · ec34686 · ec34686
1 parent cc9fbfc
commit ec34686
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/Request/DtoExtractor.php b/Request/DtoExtractor.php
@@ -17,6 +17,7 @@
 use StfalconStudio\ApiBundle\Service\AttributeProcessor\DtoAttributeProcessor;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
+use Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer;
 use Symfony\Component\Serializer\SerializerInterface;
 
 /**
@@ -59,7 +60,10 @@ public function getDtoFromRequestForDtoClass(Request $request, string $dtoClassN
     {
         $context = [];
         if (null !== $objectToPopulate) {
-            $context = [AbstractNormalizer::OBJECT_TO_POPULATE => $objectToPopulate];
+            $context = [
+                AbstractNormalizer::OBJECT_TO_POPULATE => $objectToPopulate,
+                AbstractObjectNormalizer::DEEP_OBJECT_TO_POPULATE => true,
+            ];
         }
 
         $object = $this->serializer->deserialize($request->getContent(), $dtoClassName, 'json', $context);

diff --git a/Tests/Request/DtoExtractorTest.php b/Tests/Request/DtoExtractorTest.php
@@ -21,6 +21,7 @@
 use StfalconStudio\ApiBundle\Service\AttributeProcessor\DtoAttributeProcessor;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
+use Symfony\Component\Serializer\Normalizer\AbstractObjectNormalizer;
 use Symfony\Component\Serializer\SerializerInterface;
 
 /**
@@ -88,8 +89,17 @@ public function testGetDtoFromRequestWithoutPopulation(?object $objectToPopulate
 
     public static function dataProvider(): iterable
     {
-        yield [null, []];
-        yield [new \stdClass(), [AbstractNormalizer::OBJECT_TO_POPULATE => new \stdClass()]];
+        yield [
+            'objectToPopulate' => null,
+            'context' => [],
+        ];
+        yield [
+            'objectToPopulate' => new \stdClass(),
+            'context' => [
+                AbstractNormalizer::OBJECT_TO_POPULATE => new \stdClass(),
+                AbstractObjectNormalizer::DEEP_OBJECT_TO_POPULATE => true,
+            ]
+        ];
     }
 
     public function testExceptionOnDtoWithoutInterface(): void