Add enableSelectionMode for DialogList #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should close issue #29. I believe that providing the user with the whole list of DIALOG objects is a bit "dangerous", users can modify that collection and feed it back to the adapter and given the current implementation that's not something we might want. So having a ```getDialogPosition()``` method should solve the case when the user needs to have the current adapter position of a certain dialog.
Just small change here `* adapter.addItem(DIALOG dialog) - adds one dialog to the end of the list * adapter.addItem(int position, DIALOG dialog) - adds a new dialog to the specified position.`
Add sample
Add TypingListener to docs
…ppropriate Useful when connecting adapter directly to streaming data source Changed update methods to return boolean
Update COMPONENT_DIALOGS_LIST.MD
This reverts commit f2e5cc7.
A typographic error was made in the documentation for the DialogList component under the 'Prepare your model' section. "IDialog" was written as "IDealog". This pull request corrects that error.
Add the option for nullable to distinguish between a message and image. Useful for when using Kotlin.
If some empty list passed to insert at the end, will crash with a indexOutOfBounds. To avoid this, it's recomended to add a check to see if the list is empty or not. And adding a @NotNull anotation to the param will be useful to use it with Kotlin. If you don't like a "fast" return, do it with a tipical if.
Enable payloads for custom content types
Update documentation to add upsertItem method
- List<Wrapper> items - method `generateDateHeaders`
Added upsert method to move a specific item to the start.
Link for [custom layout looks like](https://github.com/stfalcon-studio/ChatKit/blob/master/sample/src/main/res/layout/item_custom_dialog.xml) at line 224 is broken.
Migrated to AndroidX and Java 8
Updated broken link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be very useful to add also to DialogList the functionality "enableSelectionMode" so that you can delete and perform other actions on the dialogs