PSyclone release 2.4.0

[TeranIvy]

The related fparser 0.1.2 release issue is stfc/fparser#419.

Update 1: going with fparser 0.1.1 (see comment below).

Update 2: going with fparser 0.1.2 (see comment below).

Update 3: going with fparser 0.1.3 (see comment below).

Update 4: Terry reported an issue with PSyAD following the recent merge of #2233. Added the follow-up issue, #2335.

Update 5: we agreed that #2335 is not a priority for this release so I removed it. I will do one final testing of LFRic before I conclude the task list as completed.

Required PSyclone issues/PRs to be completed (20/09/2023):

• PR (Closes #2109) Update to fparser 0.1.1 #2121 for Move to fparser 0.1.1 #2109,
• PR For #2159 - new precision fields #2160 for New precision fields #2159,
• Outdated tutorials #1833 (PR to follow).
• (towards #2132) LFRic integration tests #2218

Update on the related PSyclone PRs/issues;

• PR Readthedocs failed to build the reference guide on master #2242 (fixed on master),
• PR For #2316: Update setup.py to fparser 0.1.3 #2328 for Update fparser version in setup.py #2316,
• PR (Closes #95, #994) enforce valid Fortran names for invoke names #2154 for [LFRic] Forbid white space in Invoke names. #95,
• PR (Closes #2253) allow for GH_WRITE access to continuous field args to inter-grid kernels #2287 for [LFRic] Error when using GH_WRITE and continuous fields in intergrid kernels #2253,
• PR Correct kernel metadata for LFRic adjoint code (closes #1772) #2233 for modify Adjoint metadata #1772,
• PR #2305 Renamed DynHaloExchange to LFRicHaloExchange #2306 for DynHaloExchange to LFRicHaloExchange #2305,
• PR Fix missing back tic in docstrings #2334,
• Full LFRic test suite successful.

[TeranIvy]

Update: fparser did not support module procedure :: (F2008 standard) so that was fixed in stfc/fparser#406 (associated issue stfc/fparser#405)

[TeranIvy]

Update: fparser was throwing a syntax error when parsing source which INCLUDEs an INTERFACE block. That was fixed in stfc/fparser#414.

[arporter]

Created branch 2108_release240 and updated fparser on this branch to permit testing by @TeranIvy or @mo-lottieturner :-)

[TeranIvy]

@arporter, I am happy to report that everything is fine with the new fparser 😃

[arporter]

@TeranIvy and @mo-lottieturner, I've just brought the branch associated with this Issue up-to-date with master.
How do you want to proceed with making a release?

[arporter]

@sergisiso has suggested getting #2218 on as well as that has some LFRic fixes.

[arporter]

#2218 is on master now.

[arporter]

I've updated the associated branch although you could just test with master. I'll let @TeranIvy, @mo-lottieturner, @sergisiso and @rupertford take it from here...

[TeranIvy]

PSyclone setup.py still requires fparser 0.1.1, and when installing PSyclone from the master or a branch it pulls in both fparser 0.1.1 release and 0.1.2 submodule. I will issue a PR for this as it is complicating testing on our end.

Update: We decided to go with fparser 0.1.3 (stfc/fparser#427).

[arporter]

We need to fix ReadTheDocs builds #2242 before making a release too.

[TeranIvy]

@rupertford, @arporter, @sergisiso and @hiker, I updated the issue with required tasks/PRs. Please check whether I forgot something 😄

[TeranIvy]

LFRic test suite on Spice ran successfully with the latest PSyclone master.

[arporter]

I've updated the version number and rebuilt the UG. Just waiting for the integration tests now.

[arporter]

Integration tests are all fine. Will proceed to merge.