Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploads #9

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Uploads #9

wants to merge 10 commits into from

Conversation

Cbameron12
Copy link
Collaborator

Added the upload helper, router and main. Checked with pre-commit.

@Cbameron12 Cbameron12 linked an issue Jan 17, 2025 that may be closed by this pull request
api/utils/upload_helper.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Outdated Show resolved Hide resolved
main.py Outdated Show resolved Hide resolved
@ElliottKasoar
Copy link
Member

I know this is just prototype code, but if there are very simple tests e.g. calculate the hash on a minimal file before/after chunking, and if there's a way of seeing what happens when the hashes don't agree, that would be great.

tests/test_upload_helper.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Show resolved Hide resolved
api/utils/upload_helper.py Outdated Show resolved Hide resolved
api/utils/upload_helper.py Outdated Show resolved Hide resolved
api/utils/upload_helper.py Outdated Show resolved Hide resolved
api/utils/upload_helper.py Outdated Show resolved Hide resolved
api/utils/upload_helper.py Outdated Show resolved Hide resolved
api/utils/upload_helper.py Outdated Show resolved Hide resolved
api/utils/upload_helper.py Outdated Show resolved Hide resolved
api/utils/upload_helper.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Outdated Show resolved Hide resolved
api/endpoints/upload_route.py Outdated Show resolved Hide resolved

Returns
-------
list of str
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
list of str
list[str]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create getter for filenames of uploaded files
2 participants