Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-67348 Avoid deprecated method #122

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

csierra
Copy link

@csierra csierra commented Sep 4, 2018

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@@ -141,8 +142,12 @@ protected void sendError(
PortletURL portletURL = PortletURLFactoryUtil.create(
request, PortletKeys.LOGIN, PortletRequest.RENDER_PHASE);

portletURL.setParameter(
MutableRenderParameters renderParameters =
portletURL.getRenderParameters();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this exception...

Caused by: java.lang.UnsupportedOperationException: Requires 3.0 opt-in
	at com.liferay.portlet.internal.PortletURLImpl.getRenderParameters(PortletURLImpl.java:298)

But it looks like we only support Portlet 2 still?
https://github.com/liferay/liferay-portal/blob/master/portal-impl/src/com/liferay/portal/service/impl/PortletLocalServiceImpl.java#L2508

Copy link
Owner

@stian-sigvartsen stian-sigvartsen Nov 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csierra If you agree I am going to leave this commit out because it is only available in the portlet 3.0 API. So we can backport easier. See @topolik 's comment on another use of portlet 3.0 in similar OpenId Connect code: brianchandotcom@24df85d

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure... go ahead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants