Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Imenu support for easy navigation. #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carltonf
Copy link

@carltonf carltonf commented May 3, 2015

No description provided.

@omajid
Copy link

omajid commented Oct 21, 2016

Some version of this would be great to have. Navigation by sections just makes so much sense in longer spec files. I have an alternate implementation at omajid@dde79cd.

@Thaodan
Copy link

Thaodan commented Oct 27, 2022

The PR uses (easy-menu-add) however it is obsolete since Emacs 28.1
and doesn't do anything.

See their note:

This function is obsolete since 28.1; this was always a no-op in Emacs
and can be safely removed.

@Thaodan
Copy link

Thaodan commented Oct 27, 2022

The patch also uses (add-to-list) for rpm-imenu-index however this doesn't work.

See Emacs output here:

lib/rpm-spec-mode/rpm-spec-mode.el:682:8: Error: ‘add-to-list’ can’t use lexical var ‘rpm-imenu-index’; use ‘push’ or ‘cl-pushnew’

@Thaodan
Copy link

Thaodan commented Oct 27, 2022

See here for fixes for those issues:
https://github.com/Thaodan/rpm-spec-mode/tree/add-imenu-support-fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants