Feature - add generic command handling #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name e.g. device.temperature() to set the temperature Added some helpful debug logs
… more conventional commands Fixed indents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main change is line 575 of the smart app. It checks if the device supports the command being sent and calls it directly even when no action is specified in the capabilities map.
This allows virtual devices that implement commands with the same name as the capability state (e.g. temperature()) to just work.
For temperature and humidity I did add actions that call temperate or setTemperature depending on which is supported (I have seen both used).
This should help people who are using the virtual sensors from smartthings with this bridge. A better sensor device handler fully compatible with this bridge is available here: https://github.com/gandazgul/mqtt-smartthings-devices/blob/master/devicetypes/gandazgul/mqtt-temperature-sensor.src/mqtt-temperature-sensor.groovy