Migrate CMake deps to FetchContent and more std:: usage #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getting rid of setup_dep CMake helper also contains some s/std/boost/ to remove few boost submodules std::thread std::tuple std::chrono std::bind (but boost::bind is still required indirectly) at last, some minor fixes to compile without warning
ilelann
commented
Jul 10, 2021
| @@ -17,11 +17,7 @@ | |||
| #include <unordered_map> | |||
| #include <vector> | |||
|
|
|||
| #ifdef ADOBE_BUILT_WITH_CMAKE | |||
| #include <double-conversion/double-conversion.h> | |||
There was a problem hiding this comment.
not sure how non-CMake build setups will react to that :)
camio
requested changes
Jul 15, 2022
| build_asl/ | ||
|
|
||
| # CLion | ||
| cmake-build-*/ |
There was a problem hiding this comment.
IDE and editor-specific files should be added to global .gitignore files instead of project ones. See this stack overflow article.
Agreed. I will split the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting rid of setup_dep CMake helper
also contains some s/std/boost/ to remove few boost submodules
std::thread
std::tuple
std::chrono
std::bind (but boost::bind is still required indirectly)
at last, some minor fixes to compile without warning