Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken MacOS CI and switch to XCode's compiler #467

Closed
camio opened this issue Jul 15, 2022 · 4 comments
Closed

Fix broken MacOS CI and switch to XCode's compiler #467

camio opened this issue Jul 15, 2022 · 4 comments

Comments

@camio
Copy link
Contributor

camio commented Jul 15, 2022

The CI for MacOS broke again. Also, @dabrahams pointed out that it is unusual for Mac users to use the compiler distributed with brew so it would likely be more useful to test against the compiler distributed with XCode.

Acceptance Criteria

  • The MacOS job works again.
  • Change the job to use the stock compiler distributed with XCode instead of one in brew.
@dabrahams dabrahams mentioned this issue Jul 15, 2022
dabrahams added a commit to dabrahams/stlab-libraries that referenced this issue Jul 15, 2022
@camio
Copy link
Contributor Author

camio commented Jul 15, 2022

Reopening because there was tech debt introduced with #470.

@camio camio reopened this Jul 15, 2022
@dabrahams
Copy link
Contributor

dabrahams commented Jul 15, 2022

@camio I don't believe that's the case. The inconsistency is not new, just different. What is the new tech debt?
Also I opened #473 for that issue, which is not this issue. How does it serve anybody to have an issue titled “Fix broken MacOS CI and switch to XCode's compiler” when both of those tasks are done?

@camio
Copy link
Contributor Author

camio commented Jul 15, 2022

We should probably discuss in the team meeting. It relates to our general "definition of done" for a task. Implicit acceptance criteria, in my mind, includes documentation/testing/and not knowingly introducing tech debt. In this case, the tech debt introduced is that we changed the version of the compiler from 13.0.1 to 13.0.0 and this line and this line were not updated to reflect that change.

@camio
Copy link
Contributor Author

camio commented Jul 16, 2022

Closing this issue.

@camio camio closed this as completed Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants