Fix CI #470
Merged
Fix CI #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #467 |
camio
requested changes
Jul 15, 2022
|
I'm assuming that the specification I linked to is correct. I have no reason to believe otherwise. Also Clang/LLVM 13.1.6 is available, but using the macOS 12.4 image as specified here. I'd rather a new inconsistency not be introduced in a PR. IMO we generally shouldn't knowingly introduce tech debt in a PR. |
IMO CI being broken is an emergency, and this is a priority inversion. With the change it is no more inconsistent than it was. It said "apple clang 13.0.1" but that's not what we were testing; it was “stock clang 13.0.1”. This PR is clearly forward progress, and PR review shouldn't stand in the way of that. Sorry, I'm making the call and merging. See #473. |
camio
added a commit
to camio/stlab-libraries
that referenced
this pull request
Jul 15, 2022
camio
added a commit
that referenced
this pull request
Jul 16, 2022
|
IMO that should be done after #472. OK?
… On Jul 15, 2022, at 9:36 AM, David Sankel ***@***.***> wrote:
@camio requested changes on this pull request.
Looks good. Could you also please update https://github.com/stlab/libraries/blob/75418397bbedf7a1b11ce5ce05d1f670945e7a22/.github/matrix.json#L16 <https://github.com/stlab/libraries/blob/75418397bbedf7a1b11ce5ce05d1f670945e7a22/.github/matrix.json#L16> with whatever version number we're using now? Based on this <https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md> it looks like this results in a switch to 13.0.0.
—
Reply to this email directly, view it on GitHub <#470 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAKYILHDSKP25XLUYSXNVTVUGHR5ANCNFSM53VTKPVA>.
You are receiving this because you authored the thread.
|
|
I don't mind. In my mind, this is old tech debt and gets lumped in with all
the rest as far as priority goes.
On Tue, Oct 11, 2022 at 3:02 AM Dave Abrahams ***@***.***>
wrote:
… IMO that should be done after #472. OK?
> On Jul 15, 2022, at 9:36 AM, David Sankel ***@***.***> wrote:
>
>
> @camio requested changes on this pull request.
>
> Looks good. Could you also please update
https://github.com/stlab/libraries/blob/75418397bbedf7a1b11ce5ce05d1f670945e7a22/.github/matrix.json#L16
<
https://github.com/stlab/libraries/blob/75418397bbedf7a1b11ce5ce05d1f670945e7a22/.github/matrix.json#L16>
with whatever version number we're using now? Based on this <
https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md>
it looks like this results in a switch to 13.0.0.
>
> —
> Reply to this email directly, view it on GitHub <
#470 (review)>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AAAKYILHDSKP25XLUYSXNVTVUGHR5ANCNFSM53VTKPVA
>.
> You are receiving this because you authored the thread.
>
—
Reply to this email directly, view it on GitHub
<#470 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4YR24PRP3PWJKBJ2K4IBDWCUGKHANCNFSM53VTKPVA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes our claims of testing with Apple clang not-a-lie.