-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second try at adding PTP support #462
Open
HarishgunaS
wants to merge
35
commits into
stm32-rs:master
Choose a base branch
from
parallelsystems:ptp-take2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @richardeoin, this PR is ready. Please review if and when you have time. Thanks! |
@richardeoin I'd love if you could review and merge this as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The company that I am working at requires PTP leader/follower support on an STM32 H7 series microcontroller. This PR adds PTP support for the H7. It is a revised version of #444.
Description
All the PTP related features that have been added in this PR are completely feature gated, so that use without the PTP feature is completely unaffected.
There are three major parts of this implementation.
EthernetDMA
, since smoltcp would drop any PTP frames oninterface.poll
.The author of a related PR on a different repo had concerns about the Rx pipeline being stalled due to timestamps being stored in a context descriptor that is owned by the application and blocking the DMA. To minimize concerns regarding this, I ran a
ping
flood against the microcontroller using theptp-take2
branch HAL as well as themain
branch HAL, and the results were basically identical.Validation
Wireshark output of packets emitted by the micro, showing timestamped PTP followup packets.
Ping flooding the micro with no packet loss.