Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: peek() function always return first byte of data #86

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix: peek() function always return first byte of data #86

merged 1 commit into from
Sep 11, 2024

Conversation

patricklaf
Copy link
Contributor

Fix for issue #85

@fpistm fpistm self-requested a review July 10, 2024 12:15
@fpistm fpistm added the enhancement New feature or request label Jul 10, 2024
@fpistm fpistm added this to the 1.4.1/1.5.0 milestone Jul 10, 2024
@fpistm fpistm added fix 🩹 Bug fix and removed enhancement New feature or request labels Sep 11, 2024
fpistm
fpistm approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested both UDP and TCP.
Thanks @patricklaf for the fix.

@fpistm fpistm merged commit cc8310f into stm32duino:main Sep 11, 2024
3 checks passed
@fpistm fpistm linked an issue Sep 11, 2024 that may be closed by this pull request
peek() function allways return first byte of data #85
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
fix 🩹 Bug fix
Projects
STM32duino libraries
Status: Done
Milestone
1.4.1/1.5.0
Development

Successfully merging this pull request may close these issues.

peek() function allways return first byte of data
2 participants
@patricklaf @fpistm