Marshal hubSize from MCE spec (#654)

Signed-off-by: Nathaniel Graham <[email protected]>

api/v1/multiclusterengine_methods.go

@@ -18,7 +18,10 @@ limitations under the License.
 
 package v1
 
-import "fmt"
+import (
+	"encoding/json"
+	"fmt"
+)
 
 const (
 	AssistedService              = "assisted-service"
@@ -212,6 +215,26 @@ func IsInHostedMode(mce *MultiClusterEngine) bool {
 	return false
 }
 
+func (h HubSize) String() string {
+	return HubSizeStrings[h]
+}
+
+func (h *HubSize) UnmarshalJSON(b []byte) error {
+	fmt.Println("Unmarshaling JSON is occuring")
+	var hubsize string
+	if err := json.Unmarshal(b, &hubsize); err != nil {
+		return err
+	}
+
+	var exists bool
+	*h, exists = HubSizeFromString[hubsize]
+
+	if !exists {
+		return fmt.Errorf("key %v does not exist in map", hubsize)
+	}
+	return nil
+}
+
 /*
 GetLegacyPrometheusKind returns a list of legacy kind resources that are required to be removed before updating to
 ACM 2.9 and later.

api/v1/multiclusterengine_methods_test.go

@@ -1,6 +1,7 @@
 package v1_test
 
 import (
+	"encoding/json"
 	"testing"
 
 	. "github.com/onsi/ginkgo/v2"
@@ -172,3 +173,65 @@ func TestGetLegacyServiceMonitorName(t *testing.T) {
 		})
 	}
 }
+
+func TestHubSizeDefault(t *testing.T) {
+	tests := []struct {
+		name string
+		spec api.MultiClusterEngineSpec
+		want api.HubSize
+	}{
+		{
+			name: "Default is Medium",
+			spec: api.MultiClusterEngineSpec{},
+			want: api.Medium,
+		},
+		{
+			name: "Override Default with Large",
+			spec: api.MultiClusterEngineSpec{
+				HubSize: api.Large,
+			},
+			want: api.Large,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			hsize := tt.spec.HubSize
+			if hsize != tt.want {
+				t.Errorf("HubSize: %v, want: %v", hsize, tt.want)
+			}
+		})
+	}
+}
+
+func TestHubSizeMarshal(t *testing.T) {
+	tests := []struct {
+		name       string
+		yamlstring string
+		want       api.HubSize
+	}{
+		{
+			name:       "Marshal defaults to M",
+			yamlstring: `{}`,
+			want:       api.Medium,
+		},
+		{
+			name:       "Marshals when overriding default with large",
+			yamlstring: `{"hubSize": "L"}`,
+			want:       api.Large,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			var out api.MultiClusterEngineSpec
+			t.Logf("spec before marshal: %v\n", out)
+			err := json.Unmarshal([]byte([]byte(tt.yamlstring)), &out)
+			t.Logf("spec after marshal: %v\n", out)
+			if err != nil {
+				t.Errorf("Unable to unmarshal yaml string: %v. %v", tt.yamlstring, err)
+			}
+			if out.HubSize != tt.want {
+				t.Errorf("Hubsize not desired. HubSize: %v, want: %v", out.HubSize, tt.want)
+			}
+		})
+	}
+}

api/v1/multiclusterengine_types.go

@@ -26,6 +26,31 @@ import (
 // AvailabilityType ...
 type AvailabilityType string
 
+type HubSize uint8
+
+// Putting medium first here defaults it to Medium
+const (
+	Medium = iota
+	Small
+	Large
+	ExtraLarge
+)
+
+var (
+	HubSizeStrings = map[HubSize]string{
+		Small:      "S",
+		Medium:     "M",
+		Large:      "L",
+		ExtraLarge: "XL",
+	}
+	HubSizeFromString = map[string]HubSize{
+		"S":  Small,
+		"M":  Medium,
+		"L":  Large,
+		"XL": ExtraLarge,
+	}
+)
+
 // DeploymentMode
 type DeploymentMode string
 
@@ -50,6 +75,11 @@ type MultiClusterEngineSpec struct {
 	// Set the nodeselectors
 	NodeSelector map[string]string `json:"nodeSelector,omitempty"`
 
+	// The resource allocation bucket for this hub to use.
+	// [S (Small), M (Medium), L (Large), XL (Extra Large)]. Defaults to (M)edium if not specified.
+	//+operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Hub Size",xDescriptors={"urn:alm:descriptor:com.tectonic.ui:hidden"}
+	HubSize HubSize `json:"hubSize,omitempty"`
+
 	// Override pull secret for accessing MultiClusterEngine operand and endpoint images
 	//+operator-sdk:csv:customresourcedefinitions:type=spec,displayName="Image Pull Secret",xDescriptors={"urn:alm:descriptor:io.kubernetes:Secret","urn:alm:descriptor:com.tectonic.ui:advanced"}
 	ImagePullSecret string `json:"imagePullSecret,omitempty"`

config/crd/bases/multicluster.openshift.io_multiclusterengines.yaml

@@ -53,6 +53,17 @@ spec:
                 description: 'Specifies deployment replication for improved availability.
                   Options are: Basic and High (default)'
                 type: string
+              hubSize:
+                description: The resource allocation bucket for this hub to use.
+                  [S (Small), M (Medium), L (Large), XL (Extra Large)]. Defaults to
+                  (M)edium if not specified.
+                type: string
+                enum:
+                  - S
+                  - M
+                  - L
+                  - XL
+                default: M
               imagePullSecret:
                 description: Override pull secret for accessing MultiClusterEngine
                   operand and endpoint images