-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable autoimport for hypershift addon #1138
disable autoimport for hypershift addon #1138
Conversation
Signed-off-by: Zhiwei Yin <[email protected]>
/cherry-pick backplane-2.7 |
@zhiweiyin318: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @rokej |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not want to disable this in the product in general because ACM/MCE users rely on this. We should only disable this in a specific environment that requires this.
Quality Gate passedIssues Measures |
Another question for @cameronmwall will MCE reconcile it back when it is changed by the user manually? |
@zhiweiyin318 User manual changes in that addon config will not be reconciled by the installer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed the condition. Approved. Thanks.
/override ci/prow/test-unit |
@dislbenn: Overrode contexts on behalf of dislbenn: ci/prow/test-unit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dislbenn, rokej, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zhiweiyin318: new pull request created: #1139 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Please provide a brief description of the purpose of this pull request.
Related Issue
https://issues.redhat.com/browse/ACM-16459
Changes Made
Provide a clear and concise overview of the changes made in this pull request.
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist
Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line:
/cc @reviewer1 @reviewer2
Definition of Done