Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable autoimport for hypershift addon #1138

Merged

Conversation

zhiweiyin318
Copy link
Contributor

Description

Please provide a brief description of the purpose of this pull request.

Related Issue

https://issues.redhat.com/browse/ACM-16459

Changes Made

Provide a clear and concise overview of the changes made in this pull request.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@zhiweiyin318
Copy link
Contributor Author

/cherry-pick backplane-2.7

@openshift-cherrypick-robot

@zhiweiyin318: once the present PR merges, I will cherry-pick it on top of backplane-2.7 in a new PR and assign it to you.

In response to this:

/cherry-pick backplane-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zhiweiyin318
Copy link
Contributor Author

/assign @rokej
/assign @cameronmwall

Copy link
Contributor

@rokej rokej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to disable this in the product in general because ACM/MCE users rely on this. We should only disable this in a specific environment that requires this.

@zhiweiyin318
Copy link
Contributor Author

@zhiweiyin318
Copy link
Contributor Author

Another question for @cameronmwall will MCE reconcile it back when it is changed by the user manually?

@rokej
Copy link
Contributor

rokej commented Dec 16, 2024

@zhiweiyin318 User manual changes in that addon config will not be reconciled by the installer.

Copy link
Contributor

@rokej rokej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the condition. Approved. Thanks.

@openshift-ci openshift-ci bot added the lgtm label Dec 16, 2024
@dislbenn
Copy link
Collaborator

/override ci/prow/test-unit

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@dislbenn: Overrode contexts on behalf of dislbenn: ci/prow/test-unit

In response to this:

/override ci/prow/test-unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dislbenn
Copy link
Collaborator

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, rokej, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0eb2005 into stolostron:main Dec 16, 2024
12 checks passed
@openshift-cherrypick-robot

@zhiweiyin318: new pull request created: #1139

In response to this:

/cherry-pick backplane-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants