Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chart for managed service account addon #514

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

zhujian7
Copy link
Contributor

@zhujian7 zhujian7 commented Sep 21, 2023

Description

Update chart for managed service account addon to:

  • ignore the managedClusterAddon.spec.installNamespace for msa addon
  • orphan the managedClusterAddon.spec.installNamespace on the managed cluster when deleting the addon
  • Update permission config in addontemplate for the managed service account addon

Related Issue

https://issues.redhat.com/browse/ACM-7602

Changes Made

  • update the generate-charts.py to change the addonDeploymentConfig namespace from value {{ .Release.Namespace }} to {{ .Values.global.namespace }} when syncing from the upstream repo
  • sync managedServiceAccount chart from the upstream repo

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

/cc @dislbenn @qiujian16

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@dislbenn
Copy link
Collaborator

/retest

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dislbenn
Copy link
Collaborator

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 646f3be into stolostron:main Sep 25, 2023
@zhujian7 zhujian7 deleted the update-msa-chart branch September 25, 2023 14:50
@birsanv
Copy link

birsanv commented Sep 25, 2023

@zhujian7 would this PR take care of existing MSA addons created in a custom namespace ?
So if I am for example on ACM 2.7 and have an MSA addon in a test-ns ns, would this fix prevent the test-ns to be deleted when upgrading to ACM 2.9 ?

@zhujian7
Copy link
Contributor Author

@birsanv Yes, this will prevent the test-ns from being deleted and will ignore the test-ns but use the open-cluster-management-agent-addon in 2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants