Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-7674] Updated MCE operand namespace to support openshift.io/cluster-monitor… #517

Merged
merged 6 commits into from
Sep 29, 2023
Merged

[ACM-7674] Updated MCE operand namespace to support openshift.io/cluster-monitor… #517

merged 6 commits into from
Sep 29, 2023

Conversation

dislbenn
Copy link
Collaborator

Description

Update the MCE operator to add the openshift.io/cluster-monitoring label to the namespace where the MCE resources are deployed. The label will be added during the operator reconciling phase.

Related Issue

https://issues.redhat.com/browse/ACM-7674

Changes Made

Updated MCE operator to update the namespace object where MCE's operands are deployed with the openshift.io/cluster-monitoring label. This will allow OpenShift to detect the namespace where the PrometheusRules and ServiceMonitors will now be deployed.

Screenshots (if applicable)

Screenshot 2023-09-26 at 12 32 02 PM

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

/cc @cameronmwall @ngraham20

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@dislbenn dislbenn changed the title [ACM-7674] updated MCE operand namespace to support openshift.io/cluster-monitor… [ACM-7674] Updated MCE operand namespace to support openshift.io/cluster-monitor… Sep 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@cameronmwall
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cameronmwall,dislbenn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2ed9bf2 into stolostron:main Sep 29, 2023
1 check passed
@dislbenn dislbenn deleted the add-openshift-label-to-ns branch October 12, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants