Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-7676] Removed additional promrules and servicemonitors from openshift-monitor… #528

Merged
merged 2 commits into from
Oct 4, 2023
Merged

[ACM-7676] Removed additional promrules and servicemonitors from openshift-monitor… #528

merged 2 commits into from
Oct 4, 2023

Conversation

dislbenn
Copy link
Collaborator

@dislbenn dislbenn commented Oct 4, 2023

…ing ns

Description

Updating MCE operator to remove additional legacy PrometheusRules and ServiceMonitors

Related Issue

https://issues.redhat.com/browse/ACM-7676

Changes Made

MCE operator will now remove the console-mce PrometheusRule and ServiceMonitor from openshift-monitoring namespace.

Screenshots (if applicable)

N/A

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@dislbenn dislbenn requested a review from ngraham20 October 4, 2023 15:24
@dislbenn dislbenn changed the title [ACM-7676] Removed addition promrules and servicemonitors from openshift-monitor… [ACM-7676] Removed additional promrules and servicemonitors from openshift-monitor… Oct 4, 2023
@openshift-ci openshift-ci bot added the approved label Oct 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.1% 87.1% Coverage
0.0% 0.0% Duplication

@dislbenn dislbenn requested a review from cameronmwall October 4, 2023 17:55
@cameronmwall
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cameronmwall,dislbenn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 65bc470 into stolostron:main Oct 4, 2023
3 checks passed
@dislbenn dislbenn deleted the remove-promrule-servicemonitor-console branch October 12, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants