improve log legibility #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cameron Wall <[email protected]> improve log legibility Signed-off-by: Cameron Wall <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cameronmwall The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
Kudos, SonarCloud Quality Gate passed! |
|
@cameronmwall I was testing the image and I see the following error: sigs.k8s.io/controller-runtime/pkg/log.(*delegatingLogSink).WithName(0xc0003f1a40, {0x1b1d88b, 0x9})
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/log/deleg.go:147 +0x4c
github.com/go-logr/logr.Logger.WithName(...)
/go/pkg/mod/github.com/go-logr/[email protected]/logr.go:336
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).getLogger.func1()
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/webhook/admission/webhook.go:182 +0x63
sync.(*Once).doSlow(0x0?, 0xc00049e500?)
/usr/local/go/src/sync/once.go:74 +0xc2
sync.(*Once).Do(...)
/usr/local/go/src/sync/once.go:65
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).getLogger(0xc0002fec80?, 0xc0002b6000?)
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/webhook/admission/webhook.go:180 +0x53
sigs.k8s.io/controller-runtime/pkg/webhook/admission.(*Webhook).ServeHTTP(0xc0002fec80, {0x7fc0d1aa87f8?, 0xc000466500}, 0xc0005b6700)
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/webhook/admission/http.go:96 +0xc34
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerInFlight.func1({0x7fc0d1aa87f8, 0xc000466500}, 0x1dedf00?)
/go/pkg/mod/github.com/prometheus/[email protected]/prometheus/promhttp/instrument_server.go:60 +0xd4
net/http.HandlerFunc.ServeHTTP(0x1dedf60?, {0x7fc0d1aa87f8?, 0xc000466500?}, 0xc0000fd828?)
/usr/local/go/src/net/http/server.go:2122 +0x2f
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerCounter.func1({0x1dedf60?, 0xc0005fe1c0?}, 0xc0005b6700)
/go/pkg/mod/github.com/prometheus/[email protected]/prometheus/promhttp/instrument_server.go:147 +0xc5
net/http.HandlerFunc.ServeHTTP(0x7d9205?, {0x1dedf60?, 0xc0005fe1c0?}, 0x40dd48?)
/usr/local/go/src/net/http/server.go:2122 +0x2f
github.com/prometheus/client_golang/prometheus/promhttp.InstrumentHandlerDuration.func2({0x1dedf60, 0xc0005fe1c0}, 0xc0005b6700)
/go/pkg/mod/github.com/prometheus/[email protected]/prometheus/promhttp/instrument_server.go:109 +0xc7
net/http.HandlerFunc.ServeHTTP(0xc0005fe1c0?, {0x1dedf60?, 0xc0005fe1c0?}, 0x1b197be?)
/usr/local/go/src/net/http/server.go:2122 +0x2f
net/http.(*ServeMux).ServeHTTP(0xc0005a83ff?, {0x1dedf60, 0xc0005fe1c0}, 0xc0005b6700)
/usr/local/go/src/net/http/server.go:2500 +0x149
net/http.serverHandler.ServeHTTP({0x1de0120?}, {0x1dedf60, 0xc0005fe1c0}, 0xc0005b6700)
/usr/local/go/src/net/http/server.go:2936 +0x316
net/http.(*conn).serve(0xc000512510, {0x1deebc0, 0xc0008c1500})
/usr/local/go/src/net/http/server.go:1995 +0x612
created by net/http.(*Server).Serve
/usr/local/go/src/net/http/server.go:3089 +0x5ed
I1120 20:04:33.078489 1 multiclusterengine_webhook.go:199] validate updatenamemulticlusterengine
I1120 20:04:33.078502 1 multiclusterengine_webhook.go:202] multicluster-engineIt seems like we would be missing additional logs within the MCE oeprator? |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change updates log format for improved log legibility
https://issues.redhat.com/browse/ACM-8351