Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite description #603

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

cameronmwall
Copy link
Contributor

Description

update API descriptions

Related Issue

https://issues.redhat.com/browse/ACM-9483
https://issues.redhat.com/browse/ACM-8981

Changes Made

Provide a clear and concise overview of the changes made in this pull request.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Cameron Wall <[email protected]>
Signed-off-by: Cameron Wall <[email protected]>
Signed-off-by: Cameron Wall <[email protected]>
Copy link

@swopebe swopebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

cameronmwall and others added 5 commits March 6, 2024 16:37
Signed-off-by: Cameron Wall <[email protected]>
Signed-off-by: Cameron Wall <[email protected]>
Signed-off-by: Cameron Wall <[email protected]>
Signed-off-by: Cameron Wall <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dislbenn
Copy link
Collaborator

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cameronmwall,dislbenn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5253735 into stolostron:main Mar 12, 2024
7 checks passed
@dislbenn
Copy link
Collaborator

/cherry-pick backplane-2.5

@openshift-cherrypick-robot

@dislbenn: new pull request created: #637

In response to this:

/cherry-pick backplane-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants