Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-10272] Added warning logs for deprecated spec field usage #632

Merged
merged 2 commits into from
Mar 7, 2024
Merged

[ACM-10272] Added warning logs for deprecated spec field usage #632

merged 2 commits into from
Mar 7, 2024

Conversation

dislbenn
Copy link
Collaborator

@dislbenn dislbenn commented Mar 7, 2024

Description

Added a warning log to indicate that a deprecated field is being used with the MCE CR spec.

Related Issue

https://issues.redhat.com/browse/ACM-10272

Changes Made

Provide a clear and concise overview of the changes made in this pull request.

Screenshots (if applicable)

Added additional logging to check if deprecated fields are being used within MCE.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

/cc @cameronmwall

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Disaiah Bennett <[email protected]>
Copy link

sonarqubecloud bot commented Mar 7, 2024

@cameronmwall
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cameronmwall, dislbenn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cameronmwall,dislbenn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9149799 into stolostron:main Mar 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants