Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACM-10761] Added RHTAP dockerfile #658

Merged
merged 4 commits into from
Apr 29, 2024
Merged

[ACM-10761] Added RHTAP dockerfile #658

merged 4 commits into from
Apr 29, 2024

Conversation

dislbenn
Copy link
Collaborator

@dislbenn dislbenn commented Apr 2, 2024

Description

Adding new Dockerfile to for Konflux enablement.

Related Issue

https://issues.redhat.com/browse/ACM-10761

Changes Made

Added new Dockerfile for upstream sources.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Signed-off-by: Disaiah Bennett <[email protected]>
dislbenn added 3 commits April 5, 2024 13:42
Signed-off-by: Disaiah Bennett <[email protected]>
Signed-off-by: Disaiah Bennett <[email protected]>
Copy link
Contributor

@ngraham20 ngraham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
1 Security Hotspot
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@openshift-merge-bot openshift-merge-bot bot merged commit ce530a6 into stolostron:main Apr 29, 2024
7 checks passed
@dislbenn
Copy link
Collaborator Author

dislbenn commented Jun 3, 2024

/cherry-pick backplane-2.5

@openshift-cherrypick-robot

@dislbenn: #658 failed to apply on top of branch "backplane-2.5":

Applying: added RHTAP dockerfile
Applying: updated dockerfiles
Using index info to reconstruct a base tree...
M	Dockerfile.test.prow
Falling back to patching base and 3-way merge...
Auto-merging Dockerfile.test.prow
CONFLICT (content): Merge conflict in Dockerfile.test.prow
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 updated dockerfiles
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick backplane-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-bot bot pushed a commit that referenced this pull request Jun 6, 2024
* [ACM-10761] Added RHTAP dockerfile (#658)

* added RHTAP dockerfile

Signed-off-by: Disaiah Bennett <[email protected]>

* updated dockerfiles

Signed-off-by: Disaiah Bennett <[email protected]>

* revert Dockerfile.test.prow

Signed-off-by: Disaiah Bennett <[email protected]>

---------

Signed-off-by: Disaiah Bennett <[email protected]>

* updated tekton dockerfile refs

Signed-off-by: Disaiah Bennett <[email protected]>

* removed non-release files

Signed-off-by: Disaiah Bennett <[email protected]>

* updated tekton dockerfile refs

Signed-off-by: Disaiah Bennett <[email protected]>

* updated .dockerignore

Signed-off-by: Disaiah Bennett <[email protected]>

* updated image ref to rhel9

Signed-off-by: Disaiah Bennett <[email protected]>

---------

Signed-off-by: Disaiah Bennett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants