Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added InternalEngineComponent CR spawning to reconcile #886

Merged
merged 49 commits into from
Aug 22, 2024

Conversation

ngraham20
Copy link
Contributor

@ngraham20 ngraham20 commented Aug 6, 2024

Description

Please provide a brief description of the purpose of this pull request.

Related Issue

If applicable, please reference the issue(s) that this pull request addresses.

Changes Made

Provide a clear and concise overview of the changes made in this pull request.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • [ x] I have added/updated relevant unit tests (if applicable).
  • [ x] I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@dislbenn
Copy link
Collaborator

dislbenn commented Aug 7, 2024

/test all

@dislbenn
Copy link
Collaborator

/retest

1 similar comment
@dislbenn
Copy link
Collaborator

/retest

@ngraham20 ngraham20 force-pushed the internalhubcomponent branch from 037b5eb to d915bab Compare August 20, 2024 17:00
@ngraham20
Copy link
Contributor Author

/retest

1 similar comment
@ngraham20
Copy link
Contributor Author

/retest

@ngraham20 ngraham20 changed the title Added InternalHubComponent CR spawning to reconcile Added InternalEngineComponent CR spawning to reconcile Aug 22, 2024
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
Signed-off-by: Nathaniel Graham <[email protected]>
@ngraham20 ngraham20 force-pushed the internalhubcomponent branch from c8d72e0 to af7956f Compare August 22, 2024 18:07
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.7% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@dislbenn
Copy link
Collaborator

/override ci/prow/sonar-pre-submit "SonarCloud Code Analysis"

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

@dislbenn: Overrode contexts on behalf of dislbenn: SonarCloud Code Analysis, ci/prow/sonar-pre-submit

In response to this:

/override ci/prow/sonar-pre-submit "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dislbenn
Copy link
Collaborator

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 02b6162 into stolostron:main Aug 22, 2024
8 of 9 checks passed
@ngraham20 ngraham20 deleted the internalhubcomponent branch August 22, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants