Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prom operator to v0.73.2 #39

Closed

Conversation

coleenquadros
Copy link

@coleenquadros coleenquadros commented May 16, 2024

simonpasquier and others added 30 commits December 23, 2023 23:17
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.17.0 to 1.18.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.17.0...v1.18.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…dependabot/go_modules/github.com/prometheus/client_golang-1.18.0

build(deps): bump github.com/prometheus/client_golang from 1.17.0 to 1.18.0
…date-status-metrics

feat: add metrics tracking status updates
From a comment while reviewing prometheus-operator#6153.

Signed-off-by: Simon Pasquier <[email protected]>
…-gen-scrapeconfig

chore: refactor generateScrapeConfig()
Bumps [github.com/prometheus-community/prom-label-proxy](https://github.com/prometheus-community/prom-label-proxy) from 0.7.0 to 0.8.0.
- [Release notes](https://github.com/prometheus-community/prom-label-proxy/releases)
- [Changelog](https://github.com/prometheus-community/prom-label-proxy/blob/main/CHANGELOG.md)
- [Commits](prometheus-community/prom-label-proxy@v0.7.0...v0.8.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus-community/prom-label-proxy
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…dependabot/go_modules/github.com/prometheus-community/prom-label-proxy-0.8.0

build(deps): bump github.com/prometheus-community/prom-label-proxy from 0.7.0 to 0.8.0
PR prometheus-operator#6001 updated the `go.mod` file under `pkg/apis/monitoring` to depend
on `github.com/prometheus-operator/prometheus-operator` which isn't
desired: the goal is that external projects can import
`github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring`
pulling as few dependencies as possible.

This commit removes the unneeded dependency by moving the validation
function to the `pkg/prometheus` directory.

Signed-off-by: Simon Pasquier <[email protected]>
…is-gomod

chore: fix pkg/apis/monitoring/go.mod
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.5.0 to 0.6.0.
- [Commits](golang/sync@v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…dependabot/go_modules/golang.org/x/sync-0.6.0

build(deps): bump golang.org/x/sync from 0.5.0 to 0.6.0
* Add proposal for automated sharding

Signed-off-by: Arthur Silva Sens <[email protected]>

* Update Documentation/proposals/202310-shard-autoscaling.md

* Update Documentation/proposals/202310-shard-autoscaling.md

* Update Documentation/proposals/202310-shard-autoscaling.md

* Update Documentation/proposals/202310-shard-autoscaling.md

* Update Documentation/proposals/202310-shard-autoscaling.md

* Update Documentation/proposals/202310-shard-autoscaling.md

---------

Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: Simon Pasquier <[email protected]>
This commit reorganizes the code makinguse of `SharedSecret` to reduce
duplication.

Signed-off-by: Simon Pasquier <[email protected]>
…or-tls-assets

chore: refactor ShardedSecret
* Add testing guidelines

Signed-off-by: Arthur Silva Sens <[email protected]>

* Add separate Makefile targets for e2e-tests

Signed-off-by: Arthur Silva Sens <[email protected]>

* Apply suggestions from code review

Signed-off-by: Arthur Silva Sens <[email protected]>

Co-authored-by: Simon Pasquier <[email protected]>

---------

Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: Simon Pasquier <[email protected]>
* Ensure all comments end with a period.

By enabling the godot linter

Signed-off-by: Arthur Silva Sens <[email protected]>

* Fix godot issues

Signed-off-by: Arthur Silva Sens <[email protected]>

---------

Signed-off-by: Arthur Silva Sens <[email protected]>
* Prevent mistakes with testify

By enabling testifylint

Signed-off-by: Arthur Silva Sens <[email protected]>

* Fix testifylint issues

Signed-off-by: Arthur Silva Sens <[email protected]>

---------

Signed-off-by: Arthur Silva Sens <[email protected]>
* Prevent unnecessary type conversions

By enabling the unconvert linter

Signed-off-by: Arthur Silva Sens <[email protected]>

* Fix unconvert issues

Signed-off-by: Arthur Silva Sens <[email protected]>

---------

Signed-off-by: Arthur Silva Sens <[email protected]>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.19.0 to 0.20.0.
- [Commits](golang/net@v0.19.0...v0.20.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…dependabot/go_modules/golang.org/x/net-0.20.0

build(deps): bump golang.org/x/net from 0.19.0 to 0.20.0
* feat: emit events for invalid configurations

Emit events when the controller rejects a resource, owing to an invalid
configuration.

Fixes: prometheus-operator#3611

Signed-off-by: Pranshu Srivastava <[email protected]>

* Decouple event recorder from operator metrics

Signed-off-by: Arthur Silva Sens <[email protected]>

* Only emit events if permissions were given

Signed-off-by: Arthur Silva Sens <[email protected]>

* Keep operator name consistent across telemetry

Signed-off-by: Arthur Silva Sens <[email protected]>

* Address comments

Signed-off-by: Arthur Silva Sens <[email protected]>

---------

Signed-off-by: Pranshu Srivastava <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: Pranshu Srivastava <[email protected]>
…sic auth with prometheus/alertmanager webConfigFile (prometheus-operator#6194)

* support the operator make use of the config-reloader tls and basic authentication

---------

Signed-off-by: dongjiang1989 <[email protected]>
…tor#5962)

* Add scale subresource to Prometheus/PrometheusAgent

Signed-off-by: Arthur Silva Sens <[email protected]>

* Add retry mechanism when updating Status subresource

The goal is to allow the new Prometheus-Operator version to run even with outdated CRDs.
It will try to update the Status subresource and also Scale subresource. If it fails, it will retry but without Scale-related fields.

Signed-off-by: Arthur Silva Sens <[email protected]>

* Create function to generate selector labels

Signed-off-by: Arthur Silva Sens <[email protected]>

* Add UpdateScale and GetScale methods (prometheus-operator#6197)

Signed-off-by: Arthur Silva Sens <[email protected]>

---------

Signed-off-by: Arthur Silva Sens <[email protected]>
The Kubernetes API conventions say:

> All letters in the acronym should have the same case, using the
> appropriate case for the situation.

Since no release includes the field yet, it's ok to change the name.

Signed-off-by: Simon Pasquier <[email protected]>
…tp2-fieldname

chore: fix field name to comply with conventions
…perator#6178)

* feat: add support for remaining fields in Kubernetes SD

Fixes prometheus-operator#6087

---------

Signed-off-by: Jayapriya Pai <[email protected]>
Co-authored-by: Simon Pasquier <[email protected]>
MateSousa and others added 24 commits April 2, 2024 14:19
…http-client' flag (prometheus-operator#6448)

* feat: added a check to determine if thanos support the '--prometheus.http-client' flag
…rometheus-operator#6351)

* operator cmd: check if controllers' crds are supplied

Only start each controller when its crd is provided, and fail the operator if no controllers start.

Fixes prometheus-operator#6140

* Nit

* Resolve reviews
…_sd_copy

feat: add support for Docker SD in ScrapeConfig
…rator#6177)

chore: test added

rfac: kubernetes sd role

chore: cofig.Role to lowercase

rfac: unit_test role_consts
If a user specify a non-parsable proxyUrl it was not validated/rejected
but will break reloading and restarting of Prometheus due to possible invalid syntax.
This commit adds validation and rejects the invalid ones

Signed-off-by: Jayapriya Pai <[email protected]>
…lidation

fix: add proxyURL validation for smon,pmon and probe
…ator#6436)

* ScrapeConfig CRD: add HetznerSDConfig API definition & include it under ScrapeConfig spec
chore: Add checks for selectors in KubernetesSDConfig (prometheus-operator#6177)
Allow empty separator in relabel config. This is corresponding to Prometheus' relabel config.

Fixes prometheus-operator#5003
Signed-off-by: Jayapriya Pai <[email protected]>
fix: log deprecated bearer token fields at debug level
Signed-off-by: Jayapriya Pai <[email protected]>
controller-runtime also calls `metrics.Register()` during init and this
function can be called only once. To ensure that the k8s client metrics
get updated, the global variables need to be set again by the operator.

https://github.com/kubernetes-sigs/controller-runtime/blob/67b27f27e514bd9ac4cf9a2d84dec089ece95bf7/pkg/metrics/client_go_adapter.go#L42-L55
https://github.com/kubernetes/client-go/blob/aa7909e7d7c0661792ba21b9e882f3cd6ad0ce53/tools/metrics/metrics.go#L129-L170

Signed-off-by: Simon Pasquier <[email protected]>
…-pick-6507

fix: ScrapeClass TLSConfig nil pointer exception (prometheus-operator#6507)
Signed-off-by: Jayapriya Pai <[email protected]>

Co-authored-by: Simon Pasquier <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Copy link

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coleenquadros
Once this PR has been reviewed and has the lgtm label, please assign douglascamata for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Coleen Iona Quadros <[email protected]>
@philipgough
Copy link

/retest

@philipgough philipgough self-requested a review May 21, 2024 09:54
Copy link

openshift-ci bot commented May 21, 2024

@coleenquadros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test 243a211 link true /test test
ci/prow/pr-image-mirror-prometheus-config-reloader 243a211 link true /test pr-image-mirror-prometheus-config-reloader
ci/prow/pr-image-mirror-prometheus-operator 243a211 link true /test pr-image-mirror-prometheus-operator
ci/prow/images 243a211 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.