Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blob protocol to infra integration tests #369

Merged
merged 10 commits into from
May 17, 2024
Merged

feat: add blob protocol to infra integration tests #369

merged 10 commits into from
May 17, 2024

Conversation

vasco-santos
Copy link
Contributor

@vasco-santos vasco-santos commented May 16, 2024 •
edited
Loading

Adds integration tests for blob implementation started on #353 .

This test aims to test all the main flows that MUST happen once a Blob is written:

  • Blob is written and stored on target
  • Blob is written via w3up-client
  • Blob index is stored on user space
  • Blob is retrievable from Roundabout
  • Blob blocks are retrievable from Hoverbord
  • Blob is retrievable by its root from w3link
  • Blob makes its way into Filecoin pipeline after a filecoin/offer

In addition, store-add tests are added independently to make sure old clients keep operation for writes + reads!

Follow ups:

  • @vasco-santos to create an issue to create ENV VARs for the testing names added like w3s.link hostname

@seed-deploy Seed Deploy
Copy link

seed-deploy bot commented May 17, 2024

View stack outputs

@vasco-santos vasco-santos force-pushed the feat/add-blob-protocol-to-service-integration-test branch from 5d2baf9 to c034c3a Compare May 17, 2024 08:19
@vasco-santos vasco-santos force-pushed the feat/add-blob-protocol-to-service-integration-test branch from c034c3a to 95e7adb Compare May 17, 2024 10:02
alanshaw
alanshaw reviewed May 17, 2024
View reviewed changes
test/blob.test.js
// Register the index with the service
await Index.add(serviceProps.conf, indexLink, { connection: serviceProps.connection })
// Register an upload with the service
await Upload.add(serviceProps.conf, root, shards, { connection: serviceProps.connection })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not using the @web3-storage/w3up-client for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

// Add blob using custom client to be able to access receipts

I want to have the CIDs for the Receipts so that I can make sure they exist. The upload client is fully used on integration.test.js, this is a more internal testing. Also, this way, I have access to the CID of the index that I can also check is written

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will improve docs though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, I could also do a follow up where in the client we export a function that does this that client also uses internally so that we do not need to maintain this code here

test/store.test.js
t.is(shards.length, 1)

// Invoke upload/add
await Upload.add(serviceProps.conf, root, shards, { connection: serviceProps.connection })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use an older version of the client for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted to do so, but there were some dependencies collision and I opted to get this similarly to blob tersts

@vasco-santos vasco-santos force-pushed the feat/add-blob-protocol-to-service-integration-test branch from d952e87 to a258a88 Compare May 17, 2024 14:16
@vasco-santos vasco-santos requested a review from alanshaw May 17, 2024 15:08
@vasco-santos vasco-santos force-pushed the feat/add-blob-protocol-to-service-integration-test branch from d5f51b9 to 678c2d7 Compare May 17, 2024 17:30
@vasco-santos vasco-santos force-pushed the feat/add-blob-protocol-to-service-integration-test branch from 678c2d7 to b45289d Compare May 17, 2024 17:32
@seed-deploy seed-deploy bot temporarily deployed to pr369 May 17, 2024 17:41 Inactive
@vasco-santos vasco-santos merged commit 3242d24 into main May 17, 2024
3 checks passed
@vasco-santos vasco-santos deleted the feat/add-blob-protocol-to-service-integration-test branch May 17, 2024 17:55
@alanshaw alanshaw mentioned this pull request May 20, 2024
Closed
@vasco-santos vasco-santos mentioned this pull request May 21, 2024
Merged
vasco-santos added a commit that referenced this pull request May 21, 2024
@vasco-santos
fix: add env vars to integration tests (#378)
3f1e4d3 
quick follow up from #369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @alanshaw