feat: define access/claim in @web3-storage/capabilities #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
changed the title
gobengo
commented
Jan 31, 2023
Gozala
reviewed
Jan 31, 2023
| await example({ issuer: bob }) | ||
| } | ||
| }) | ||
| }) |
There was a problem hiding this comment.
I'm not sure what this is testing exactly that no error is thrown ? I would suggest covering more surface here, specifically to ensure:
- That wrong claims fail validation when
withis mismatched. - Since you only support
did:keyanddid:mailtovalidate that those resources are ok, but other DIDs are not.
There was a problem hiding this comment.
Would you say this is a valid test for what you mean by #1?
For #2 I added:
- throws if try to create invocation using
Access.claimusing unexpectedwithdid method - 6556e21#diff-67e9cd2926c4b07ca092fa34e8015b5ed3ce81c5708473253964f5d7a0da0c4fR268 - does not authorize
access/claimwhosewithis an unexpected did method a57ef04#diff-67e9cd2926c4b07ca092fa34e8015b5ed3ce81c5708473253964f5d7a0da0c4fR282
Gozala
approved these changes
Jan 31, 2023
gobengo
commented
Jan 31, 2023
gobengo
force-pushed
the
1675129847-define-access-claim-cap
branch
from
bf99e64 to
e6b6963
Compare
… unexpected did methods
…n issuer in proofs
|
update
|
gobengo
commented
Jan 31, 2023
| @@ -3,6 +3,8 @@ import { access } from '@ucanto/validator' | |||
| import { Verifier } from '@ucanto/principal/ed25519' | |||
| import * as Access from '../../src/access.js' | |||
| import { alice, bob, service, mallory } from '../helpers/fixtures.js' | |||
| import * as Ucanto from '@ucanto/interface' | |||
There was a problem hiding this comment.
This would have required a comment to disable tsc no-unused-vars, but it no longer does because of adding jsdoc/no-undefined-types rule
related to: https://github.com/web3-storage/w3protocol/pull/392/files#r1090596726
hugomrdias
approved these changes
Feb 1, 2023
travis
pushed a commit
that referenced
this pull request
Feb 10, 2023
🤖 I have created a release *beep* *boop* --- ## [2.3.0](capabilities-v2.2.0...capabilities-v2.3.0) (2023-02-10) ### Features * add `pre` caveat to `store/list` and `upload/list` ([#423](#423)) ([a0f6d28](a0f6d28)) * add access/delegate capability parser exported from @web3-storage/capabilities ([#420](#420)) ([e8e2b1a](e8e2b1a)) * add support for access/authorize and update ([#392](#392)) ([9c8ca0b](9c8ca0b)), closes [#386](#386) * define access/claim in @web3-storage/capabilities ([#409](#409)) ([4d72ba3](4d72ba3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gobengo
pushed a commit
that referenced
this pull request
Apr 11, 2023
🤖 I have created a release *beep* *boop* --- ## [2.3.0](capabilities-v2.2.0...capabilities-v2.3.0) (2023-02-10) ### Features * add `pre` caveat to `store/list` and `upload/list` ([#423](#423)) ([9cce414](9cce414)) * add access/delegate capability parser exported from @web3-storage/capabilities ([#420](#420)) ([7834cf2](7834cf2)) * add support for access/authorize and update ([#392](#392)) ([bf41071](bf41071)), closes [#386](#386) * define access/claim in @web3-storage/capabilities ([#409](#409)) ([2fb34dd](2fb34dd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Peeja
pushed a commit
to storacha/upload-service
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [3.0.0](storacha/w3ui@solid-uploads-list-v2.0.2...solid-uploads-list-v3.0.0) (2023-03-23) ### ⚠ BREAKING CHANGES * use new account model ([storacha#400](storacha/w3ui#400)) ### Features * use new account model ([storacha#400](storacha/w3ui#400)) ([66dd20b](storacha/w3ui@66dd20b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Travis Vachon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Unblocks:
access/claimcan=./updateabilities, so may make most sense to add after feat: add support for access/authorize and update #392 which defines tools for them