This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Use kustomize for install manifest generation #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustomize applies the kustomize namespace on all the namespaced resources. Also, move operator optional environment variables to be populated using configmap via config.env file. These variables are read from the execution environment when unset.
scripts/create-manifest.sh is no longer required.
darkowlzz
added
the
do-not-merge/wip
darkowlzz
added a commit
that referenced
this pull request
Oct 20, 2020
Addition of new related image env var `RELATED_IMAGE_API_MANAGER` shifted the array index of tracing related env vars. Increment the index value to fix it. Long term fix is in #271 using kustomize.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resources. Remove the namespace from individual files.
configmap via config.env file. These variables are read from the
execution environment when unset.
is no longer required.
Commands like:
JAEGER_SERVICE_NAME=xyz OPERATOR_IMAGE=repo:tag make install-manifestcontinue to work as before.
This change will help with kubebuilder/Operator-SDK v1 project migration.
TODO: update OLM deployment to use configmap for env vars.
NOTE: This should be merged after v2.2 release.