Skip to content

Commit

Permalink
Merge pull request #137 from store2be/use-ordered-futures-in-merge
Browse files Browse the repository at this point in the history
🐛 Fix out-of-order PDFs in merge documents
  • Loading branch information
smowafy authored Oct 9, 2019
2 parents 5365f0c + 942fb0c commit c0226f5
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,15 @@

## Unreleased

### Fixes
## [0.4.1] - 2019-10-09
- Use `futures::stream::FuturesOrdered` to maintain the order of the merge PDFs.

## [0.4.0] - 2019-08-21
- Use `async-await`
- Replace `tide` with `warp`
- Save merge assets with V4 UUIDs as file names instead of using the original file names to avoid errors when users upload files with the same name.
- Reject merge requests with an empty list of documents to merge
- Bug fixes and cleanup

## [0.3.0] - 2018-05-11
- Add Sentry for error tracking
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "papers"
version = "0.4.0"
version = "0.4.1"
authors = ["store2be <[email protected]>"]
edition = "2018"

Expand Down
2 changes: 1 addition & 1 deletion src/papers/merge.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ impl Merger {
&self,
asset_paths: Vec<PathBuf>,
) -> Result<Vec<PathBuf>, failure::Error> {
let mut futures = futures::stream::FuturesUnordered::new();
let mut futures = futures::stream::FuturesOrdered::new();

for path in asset_paths.into_iter() {
let logger = self.workspace.logger().clone();
Expand Down

0 comments on commit c0226f5

Please sign in to comment.