pkg/linksharing/sharing: always close the download

Prevent orphaned downloads from accumulating. Change-Id: I753e346d7f15fcb68b3f5aa0e60c206a35fea080
storj · Jun 23, 2023 · 29972b9 · 29972b9
1 parent 0adc0d6
commit 29972b9
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/linksharing/sharing/present.go b/pkg/linksharing/sharing/present.go
@@ -126,6 +126,11 @@ func (handler *Handler) presentWithProject(ctx context.Context, w http.ResponseW
 		if (download || !wrap) && !mapOnly && len(archivePath) == 0 && rangeErr == nil {
 			d, err := project.DownloadObject(ctx, pr.bucket, pr.realKey, options)
 			if err == nil {
+				defer func() {
+					if err := d.Close(); err != nil {
+						handler.log.Debug("couldn't close the download", zap.Error(err))
+					}
+				}()
 				// set the actual offset and length
 				httpRange := optionsToRange(d.Info().System.ContentLength, options)
 				return handler.showObject(ctx, w, r, pr, project, d.Info(), d, httpRange)