Collect implementation_deps in compilation_context #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBorowiec
commented
Sep 30, 2024
| compilation_context = target[CcInfo].compilation_context | ||
| cc_infos = [target[CcInfo]] + _collect_cc_info(ctx) | ||
| merged_cc_info = cc_common.merge_cc_infos(cc_infos = cc_infos) | ||
| compilation_context = merged_cc_info.compilation_context |
There was a problem hiding this comment.
| for dep in ctx.rule.attr.deps: | ||
| if CcInfo in dep: | ||
| cc_infos.append(dep[CcInfo]) | ||
| if hasattr(ctx.rule.attr, "implementation_deps"): |
There was a problem hiding this comment.
| before_each = "-Xiwyu", | ||
| ) | ||
|
|
||
| args.add_all(["--mapping_file={}".format(m.path) for m in iwyu_mappings], before_each = "-Xiwyu") |
There was a problem hiding this comment.
Autoformatted by latest buildifier
| @@ -95,7 +104,6 @@ def _toolchain_flags(ctx, is_cpp_target): | |||
| unsupported_features = ctx.disabled_features, | |||
| ) | |||
|
|
|||
| flags = None | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First of all thanks for the great tool :)
Combined with martis42/depend_on_what_you_use it's the best solution for removing transitive dependencies.
The
depend_on_what_you_use(DWYU) tool does the same thing asIWYUbut at aBUILDfile level.However, using the
fix-alloption of that tool does differentiate between regulardepsandimplementation_deps(bazel.build/c-cpp#cc_library_arg ->implementation_deps).To make
bazel_iwyurecognize the dependencies underimplementation_deps, could you review this PR adding theimplementation_depsto theCcInfocontext of the target?References: