Improve Grammar and Clarity in Code Comments #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daulox92
requested review from
kingster-will,
sebsadface,
Spablob and
LeoHChen
as code owners
sebsadface
reviewed
Feb 4, 2025
| @@ -60,7 +60,7 @@ interface IGroupingWorkflows { | |||
|
|
|||
| /// @notice Register a group IP with a group reward pool, attach license terms to the group IP, | |||
| /// and add individual IPs to the group IP. | |||
| /// @dev ipIds must be have the same license terms as the group IP. | |||
| /// @dev ipIds must have to the same license terms as the group IP. | |||
There was a problem hiding this comment.
should be "must have", we can remove the "to" here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File: contracts/hooks/LockLicensesHook.sol
Old: who calling → New: who is calling
Reason: Added "is" for grammatical correctness.
Old: who receive → New: who receives
Reason: Changed to ensure subject-verb agreement.
File: contracts/interfaces/modules/tokenizer/IOwnableERC20.sol
Old: to whom → New: to which
Reason: Corrected usage for referring to a token.
File: contracts/interfaces/workflows/IGroupingWorkflows.sol
Old: must be have → New: must have to
Reason: Fixed grammatical accuracy.