Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): versions #1037

Merged
merged 14 commits into from
Apr 24, 2024
Merged

chore(deps): versions #1037

merged 14 commits into from
Apr 24, 2024

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Mar 25, 2024 •
edited
Loading

No description provided.

@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 10:25pm

@Reecepbcups Reecepbcups changed the title chore(deps): Dependency Bumps chore(deps): versions Mar 25, 2024
@Reecepbcups
Copy link
Member Author

Reecepbcups commented Mar 25, 2024 •
edited
Loading

Getting this same issue with the ibc-rate-limit repo I am upgrading too. sumfin' is fishy 🐟

Error: ../../../go/pkg/mod/github.com/cosmos/[email protected]/telemetry/metrics.go:195:37: undefined: expfmt.FmtText
Error: ../../../go/pkg/mod/github.com/cosmos/[email protected]/telemetry/metrics.go:203:51: undefined: expfmt.FmtText

culprit: github.com/prometheus/client_golang => github.com/prometheus/client_golang v1.18.0

@Reecepbcups Reecepbcups mentioned this pull request Mar 26, 2024
Closed
12 tasks
@Reecepbcups
Copy link
Member Author

Reecepbcups commented Mar 28, 2024 •
edited
Loading

v0.50.6 SDK in a few weeks will get the patch in to fix

using an intermediate commit on release/v0.50.x for now: v0.50.6-0.20240328122152-405471ba0d94

Reecepbcups
Reecepbcups commented Apr 5, 2024
View reviewed changes
.gitignore
examples/hyperspace/exported_state.json

go.work.sum
Copy link
Member Author

@Reecepbcups Reecepbcups Apr 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This redundant work.sum is always incorrect vs the standard go.sum's. I can't see why it is needed since it always has issues, so ignoring should be a good way to fix constant merge conflicts since adding

go.work.sym will just be freshly generated when someone go work syncs and handle with their standard go.sum's

@Reecepbcups Reecepbcups marked this pull request as ready for review April 23, 2024 21:42
@Reecepbcups Reecepbcups requested a review from a team as a code owner April 23, 2024 21:42
@Reecepbcups Reecepbcups requested a review from agouin April 23, 2024 21:42
@Reecepbcups Reecepbcups enabled auto-merge (squash) April 24, 2024 04:36
jackzampolin
jackzampolin approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Reecepbcups Reecepbcups merged commit 9c6cfa3 into main Apr 24, 2024
19 checks passed
@Reecepbcups Reecepbcups deleted the reece/ver-bumps-mar25 branch April 24, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackzampolin jackzampolin jackzampolin approved these changes

@agouin agouin Awaiting requested review from agouin agouin is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Reecepbcups @jackzampolin