fix(v7): prevent concurrent hermes operations on the same chain #1099
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
fastfadingviolets
force-pushed
the
fix/v7-hermes-lock
branch
2 times, most recently
from
b102b5d
to
6529729
Compare
|
After multiple re-runs I can not get the unit test or test-ibc-examples w/ hermes to pass here |
|
o i probably broke something; i think i'll also have to bump a timeout |
fastfadingviolets
force-pushed
the
fix/v7-hermes-lock
branch
from
6529729
to
c559a10
Compare
|
i think the tests should be good now, they're just currently failing with that transient block.db thing |
If it's not too much to ask could you possibly remove this line that is inside of the intermittently failing test case? interchaintest/examples/ibc/ics_test.go Line 101 in 2d9495c I thought we had gone through the example test cases and either removed all of these lines or commented them out so that readers could at least see that this was an option. It's not ideal to use in CI because it leads to these weird intermittent failures due to resource contention around the sqlite database file that is used in the blockdb |
Allowing them can result in "hermes create ..." commands failing because there's sequence numbers being modified by simultaneous commands.
fastfadingviolets
force-pushed
the
fix/v7-hermes-lock
branch
from
0a0ef59
to
cc61463
Compare
This can break in CI
fastfadingviolets
force-pushed
the
fix/v7-hermes-lock
branch
from
cc61463
to
d34551e
Compare
Summary
Allowing concurrent ops can result in
hermes create ...commands failing because there's sequence numbers being modified by simultaneous commands. This PR adds per-chain locks that must be acquired to e.g. create a connection or channel