Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP: v7 <- #1115] test(ics): validate consumer transactions execute #1119

Merged
merged 5 commits into from
May 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2024

ref: #1088 (comment)

TODO

* base WIP

* try the prev attempt with new migration

* attempting to bring back old + migration, no work

* working

* reduce complexity

* add p->c IBC test (fails due to TRYOPEN)

* rm unused

* move ICS functions to their own .go

* StartRelayer right after build with longer history

* touchups

* add back `StopRelayer` before `StartRelayer`

* refactor: `FinishICSProviderSetup`

* multiple ICS version checks (v3.1, 3.3, 4.0)

* local-ic: call FinishICSProviderSetup on setup

* rm `interchaintest.DefaultBlockDatabaseFilepath`

* rm `interchaintest.DefaultBlockDatabaseFilepath` from other test

(cherry picked from commit 65cce0c)

# Conflicts:
#	chain/cosmos/cosmos_chain.go
#	examples/cosmwasm/rust-optimizer/rust_optimizer_test.go
#	examples/cosmwasm/workspace-optimizer/workspace_optimizer_test.go
#	examples/ibc/ics_test.go
#	local-interchain/interchain/start.go
@mergify mergify bot requested a review from a team as a code owner May 8, 2024 19:45
@mergify mergify bot requested a review from Reecepbcups May 8, 2024 19:45
Copy link
Contributor Author

mergify bot commented May 8, 2024

Cherry-pick of 65cce0c has failed:

On branch mergify/bp/v7/pr-1115
Your branch is up to date with 'origin/v7'.

You are currently cherry-picking commit 65cce0c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   chain/cosmos/ics.go
	modified:   examples/cosmos/chain_genesis_stake_test.go
	modified:   examples/cosmos/sdk_boundary_test.go
	modified:   examples/ibc/wasm/wasm_ibc_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   chain/cosmos/cosmos_chain.go
	deleted by us:   examples/cosmwasm/rust-optimizer/rust_optimizer_test.go
	deleted by us:   examples/cosmwasm/workspace-optimizer/workspace_optimizer_test.go
	both modified:   examples/ibc/ics_test.go
	both modified:   local-interchain/interchain/start.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 10:07pm

@Reecepbcups Reecepbcups enabled auto-merge (squash) May 10, 2024 22:17
@Reecepbcups Reecepbcups merged commit 7272afc into v7 May 10, 2024
16 checks passed
@Reecepbcups Reecepbcups deleted the mergify/bp/v7/pr-1115 branch May 10, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant