Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: use relative path for chains if applicable #999

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Reecepbcups
Copy link
Member

Summary

Currently when using local-ic, the user has to input if they want to use the current directory with ICTEST_HOME=.. User input for something we should be able to assume is less than ideal.

Solution

We check if the user is in a folder with the 'chains' directory +1 file. If this matches, we use the local directory. If not, we use the standard interchaintest install location for the files

Showcase

image

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Feb 28, 2024 1:54am

@Reecepbcups Reecepbcups changed the title ux: use relative path if it exist in the cwd ux: use relative path for chains if applicable Feb 28, 2024
@Reecepbcups Reecepbcups marked this pull request as ready for review February 28, 2024 02:08
@Reecepbcups Reecepbcups requested a review from a team as a code owner February 28, 2024 02:08
Copy link
Contributor

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@Reecepbcups Reecepbcups merged commit be3ee74 into main Mar 5, 2024
16 checks passed
@Reecepbcups Reecepbcups deleted the reece/better-relative-path-ux branch March 5, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants