Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting setting profile start date on checkout level #3233

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Profile start dates are currently calculated and filtered when creating a subscription at the payment gateway. Although this works well for the vast majority of use cases, it gets complicated when custom code wants to adjust the billing amount and set a profile start date at the same time (for example, prorations).

This PR adds a support for a new profile_start_date property on the checkout level object that can be adjusted during the pmpro_checkout_level filter. This makes adjusting the profile_start_date at checkout the same process as any other level property.

This PR will also begin throwing deprecation warnings for the existing pmpro_profile_start_date filter to encourage developers to use pmpro_checkout_level. This will ensure that everyone is adjusting the profile start date in the same way and will allow us to remove the pmpro_profile_start_date filter in a future update.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@dparker1005
Copy link
Member Author

Fix for the Proration Add On to use these changes: strangerstudios/pmpro-proration#29

@dparker1005 dparker1005 added this to the 3.4 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant