chore: upgrade react version from 18 to 19 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remidej
reviewed
Jan 30, 2025
Comment on lines
-28
to
+36
| "require": "./dist/index.js", | ||
| "import": "./dist/index.mjs", | ||
| "require": "./dist/index.cjs", | ||
| "import": "./dist/index.js", | ||
| "source": "./src/index.ts", | ||
| "default": "./dist/index.js" | ||
| }, | ||
| "./package.json": "./package.json" | ||
| }, | ||
| "main": "./dist/index.js", | ||
| "module": "./dist/index.mjs", | ||
| "main": "./dist/index.cjs", | ||
| "module": "./dist/index.js", |
There was a problem hiding this comment.
do you know why these changes are needed? the previous values match what we have in the monorepo
There was a problem hiding this comment.
I tried to run the build script with no success, with this error message
`when I run yarn build I have these errors
[ERROR]
- package.json with 'type: "module"' - 'exports["."].require' must end with ".cjs"
- package.json with 'type: "module"' - 'exports["."].import' must end with ".js"`
So I followed the error message and fixed the extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Upgrade the react and react dom version from 18 to 19 (and react testing library to v16)
Why is it needed?
To uniform the react versions in the strapi repos
How to test it?
Use the blocks-react-renderer in your FE to consume the Blocks text editor data