Make clippy a mandatory test once more #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
force-pushed
the
master-clippy-run
branch
7 times, most recently
from
b7a3320 to
712ab21
Compare
mulkieran
changed the title
mulkieran
force-pushed
the
master-clippy-run
branch
from
712ab21 to
ddb76c2
Compare
Also, use flag for warning instead of environment variable. This part is only to imitate recommended way. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
clippy likes it better if we leave it out. Signed-off-by: mulhern <[email protected]>
Because clippy likes the look and they are a bit more readable, too. Signed-off-by: mulhern <[email protected]>
On the principle of least strength. Also, clippy prefers it. Signed-off-by: mulhern <[email protected]>
It's quite possible that new shouldn't have been used in these cases. Perhaps we can change some of these names later. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
According to the principle of least strength. Also, clippy prefers it. Signed-off-by: mulhern <[email protected]>
clippy thinks this is more concise. Signed-off-by: mulhern <[email protected]>
rustc does not require it any more and clippy doesn't like it. Signed-off-by: mulhern <[email protected]>
The compiler will now fail if the type cast from is unsafe to cast to a u64. Signed-off-by: mulhern <[email protected]>
clippy prefers it and it is more usual. Signed-off-by: mulhern <[email protected]>
It's just extra business. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Use unwrap_or_else instead. Signed-off-by: mulhern <[email protected]>
clippy doesn't like it. Signed-off-by: mulhern <[email protected]>
Otherwise, clippy will think that DeviceLimits type definition ought to be Copy. We don't really want it to be Copy, because there is not guarantee that it will stay so simple. Also, our purpose in passing is certainly not to have it consumed. Signed-off-by: mulhern <[email protected]>
Do eta conversion Signed-off-by: mulhern <[email protected]>
The complex types are not really worth naming, given the function's use. Signed-off-by: mulhern <[email protected]>
I think it is doing the correct thing. Signed-off-by: mulhern <[email protected]>
clippy doesn't like it. Also, using assert_matches allows the test, if it fails to be a lot more informative. Get rid of an unused method. Signed-off-by: mulhern <[email protected]>
clippy doesn't like it and using assert_eq! will yield a better error message. Signed-off-by: mulhern <[email protected]>
In all cases, it seems to be what is actually intended. Signed-off-by: mulhern <[email protected]>
All clippy lints and other clippy problems are dealt with now. Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
master-clippy-run
branch
from
ddb76c2 to
aad4451
Compare
|
This was failing on fedora-server-2 with udevadm issues, so I rebooted fedora-server-2 and re-ran. |
agrover
approved these changes
Jan 2, 2019
trgill
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #993.
All are allows or do what clippy recommends except for eaace9b, to which you might want to pay special attention.