Regression test for key set in stratis-min #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaublitz
force-pushed
the
regression-test
branch
from
e0f0a96
to
9a39190
Compare
mulkieran
approved these changes
Apr 3, 2024
|
@jbaublitz Just noting that stratis-min does not do password verification, only stratis-cli. As far as I'm concerned, the test is fine, but the input string makes it look like you expect the password to be read twice. |
jbaublitz
force-pushed
the
regression-test
branch
from
9a39190
to
73d5d24
Compare
|
We should maybe consider doing password verification, but that seems low priority. |
|
@jbaublitz Please rebase when convenient. |
Yes, we should. I filed an issue: #3593 . |
jbaublitz
force-pushed
the
regression-test
branch
from
73d5d24
to
6fd6bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3588