Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password verification for stratis-min #3595

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbaublitz
Copy link
Member

Closes #3593

@jbaublitz jbaublitz self-assigned this Apr 11, 2024
@jbaublitz jbaublitz force-pushed the issue-stratisd-3593 branch 10 times, most recently from cf403b6 to 1f16d77 Compare April 11, 2024 14:07
@jbaublitz jbaublitz force-pushed the issue-stratisd-3593 branch 9 times, most recently from 2e8d725 to 6f1eef5 Compare April 11, 2024 19:09
@jbaublitz jbaublitz force-pushed the issue-stratisd-3593 branch 2 times, most recently from 37298c2 to 2621892 Compare May 14, 2024 13:58
Copy link

Cockpit tests failed for commit 37298c2. @martinpitt, @jelly, @mvollmer please check.

Copy link

Cockpit tests failed for commit 2621892. @martinpitt, @jelly, @mvollmer please check.

Copy link

Cockpit tests failed for commit 028dc7e. @martinpitt, @jelly, @mvollmer please check.

@jbaublitz jbaublitz force-pushed the issue-stratisd-3593 branch 2 times, most recently from 49667e2 to 215f803 Compare May 14, 2024 20:58
Copy link

Cockpit tests failed for commit 49667e2. @martinpitt, @jelly, @mvollmer please check.

Copy link

Cockpit tests failed for commit 215f803. @martinpitt, @jelly, @mvollmer please check.

Copy link

Cockpit tests failed for commit 8dcbec9. @martinpitt, @jelly, @mvollmer please check.

Copy link

Cockpit tests failed for commit 911fbb0. @martinpitt, @jelly, @mvollmer please check.

@mvollmer
Copy link
Collaborator

Cockpit tests failed for commit 37298c2. @martinpitt, @jelly, @mvollmer please check.

This failure is unrelated to Stratis, please ignore. I'll investigate. (@martinpitt, can we configure things so that only the storage tests run here? Would that make sense?)

@mvollmer
Copy link
Collaborator

This failure is unrelated to Stratis, please ignore. I'll investigate.

This caused by the switch to DNF5 in Rawhide, see cockpit-project/cockpit#20467 for a fix that makes the tests green again.

@jbaublitz
Copy link
Member Author

@mvollmer Thanks for the heads up!

@jbaublitz jbaublitz marked this pull request as draft August 13, 2024 15:35
@jbaublitz jbaublitz force-pushed the issue-stratisd-3593 branch 2 times, most recently from 8a64d23 to c4e02b5 Compare August 13, 2024 15:45
@jbaublitz
Copy link
Member Author

@mulkieran Is it worth doing manual testing on this or should we wait until we can automate the testing to merge it?

@jbaublitz jbaublitz force-pushed the issue-stratisd-3593 branch 3 times, most recently from e4bd4ce to 113e402 Compare August 21, 2024 18:01
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3595
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress (long term)
Development

Successfully merging this pull request may close these issues.

Do password verification on user-entered password value in stratis-min
2 participants