Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fides Module #1073

Merged
merged 223 commits into from
Feb 5, 2025
Merged

Fides Module #1073

merged 223 commits into from
Feb 5, 2025

Conversation

d-strat
Copy link

@d-strat d-strat commented Nov 19, 2024

Fixes Issue

Changes proposed

Adding Fides Module, based on previous work of LukasForst. Updating, rewriting and enriching the base code.

Steps you followed to test the changes purposed in this PR:

  • Running Slips on test file with Fides Module in place
  • Tests for Fides Modules part
  • Tests for whole Fides Module

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot from 2024-11-19 21-22-07
Screenshot from 2024-11-19 21-21-38

Note to reviewers

Last update from stratosphereips (around Nov 15) passed the CI/CD pipelines.

d-strat added 30 commits October 3, 2024 11:26
…eers that are members of organisations specified on input.
modules/fidesModule/persistence/sqlite_db.py Outdated Show resolved Hide resolved
tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
@d-strat
Copy link
Author

d-strat commented Feb 5, 2025

All of the requests from Slack and above were fulfilled, and all tests are working (some were fixed, and all were kept). From my point of view, the Fides Module is ready.

@AlyaGomaa AlyaGomaa merged commit e8d5810 into stratosphereips:develop Feb 5, 2025
67 checks passed
@AlyaGomaa
Copy link
Collaborator

wohoooo thankssss @d-strat for all the hard work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants