Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks to verify message is not empty before querying OpenAI #7

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Add checks to verify message is not empty before querying OpenAI #7

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2aebc92
Check manual input message is valid before translating
verovaleros Feb 23, 2024
acab1cd
Re-arrange to check for limit later in the code
verovaleros Feb 23, 2024
73e6220
Check for limit later in the code
verovaleros Feb 23, 2024
1d60333
Check message is not empty before asking OpenAI
verovaleros Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions hermeneisGPT.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,23 +125,30 @@ def translate_mode_automatic(client, config, args):
for message_id, message_text in channel_messages:
logger.debug("Processing channel %s message %s (%s bytes)", args.channel_name, message_id, len(message_text))
exists_translation = exists_translation_for_message(cursor, message_id, translation_parameters_id)
if count <= limit:
if not exists_translation:

if not exists_translation:
# There is no translation for this message
if len(message_text) > 1:
count = count+1
# There is no translation for this message
logger.debug("Translating message %s with translation parameters ID %s", message_id, translation_parameters_id)

# Translate it with OpenAI model
# Message is not empty, translate it with OpenAI model
logger.debug("Translating message %s with translation parameters ID %s", message_id, translation_parameters_id)
message_translated = translate(client, config, message_text)

# Update the translation for that row
msg_translation_id = upsert_message_translation(cursor, message_id, translation_parameters_id, message_translated)
logger.debug("Message %s translated with translation ID %s", message_id, msg_translation_id)
else:
# There is a translation for this message
logger.debug("Found translation for message %s with translation parameters ID %s", message_id, translation_parameters_id)
# Message is too short (1 byte), do not translate
logger.debug("Translation cancelled for message %s, too small (%s)", message_id, message_text)
else:
# There is a translation for this message
logger.debug("Found translation for message %s with translation parameters ID %s", message_id, translation_parameters_id)

# Check if we did not reach the translation limit (number of iterations)
if count > limit:
# Translation quota reached
logger.debug("Translation limit reached, stopping translation")
break

logger.info("Finished translating %s messages for %s channel", limit, args.channel_name)
Expand Down Expand Up @@ -179,18 +186,25 @@ def translate_mode_manual(client, config):
"""
Run the LLM translation in manual interactive mode
"""
user_input_msg = "Input your message to translate:"

try:
logger.debug("Starting manual translation")
while True:
print("Input your message to translate:")
# Read user input to translate
print(user_input_msg)
input_lang_ru=input().strip()

message_translated = translate(client, config, input_lang_ru)

print(message_translated)
if input_lang_ru and input_lang_ru != user_input_msg:
message_translated = translate(client, config, input_lang_ru)
print(message_translated)
else:
# User input is empty or matched the system message
pass
except KeyboardInterrupt:
return


def main():
"""
Take a message input and use the data from the yaml file to translate
Expand Down
Loading