-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add requirements on interoperability tests #1047
Merged
plebhash
merged 1 commit into
stratum-mining:dev
from
johnnyasantoss:johnny/add-contrib
Jul 22, 2024
Merged
doc: Add requirements on interoperability tests #1047
plebhash
merged 1 commit into
stratum-mining:dev
from
johnnyasantoss:johnny/add-contrib
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Report | Mon, July 22, 2024 at 18:52:27 UTC |
Project | Stratum v2 (SRI) |
Branch | johnny/add-contrib |
Testbed | sv2 |
Click to view all benchmark results
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|
client_sv2_handle_message_common | ✅ (view plot) | 44.69 (+0.29%) | 45.23 (98.81%) |
client_sv2_handle_message_mining | ✅ (view plot) | 78.87 (+8.02%) | 80.61 (97.84%) |
client_sv2_mining_message_submit_standard | ✅ (view plot) | 14.66 (+0.02%) | 14.69 (99.75%) |
client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 260.05 (-1.63%) | 283.80 (91.63%) |
client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 586.81 (-1.24%) | 627.15 (93.57%) |
client_sv2_open_channel | ✅ (view plot) | 164.27 (-1.18%) | 174.30 (94.25%) |
client_sv2_open_channel_serialize | ✅ (view plot) | 281.04 (-0.58%) | 293.70 (95.69%) |
client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 389.96 (+3.06%) | 423.26 (92.13%) |
client_sv2_setup_connection | ✅ (view plot) | 161.58 (-1.48%) | 174.69 (92.50%) |
client_sv2_setup_connection_serialize | ✅ (view plot) | 445.89 (-5.75%) | 506.74 (87.99%) |
client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 950.63 (-2.26%) | 1,042.30 (91.20%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
Report | Mon, July 22, 2024 at 18:52:23 UTC |
Project | Stratum v2 (SRI) |
Branch | johnny/add-contrib |
Testbed | sv2 |
🚨 10 ALERTS: Threshold Boundary Limits exceeded!
Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
---|---|---|---|---|---|
client_sv2_mining_message_submit_standard | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 26.00 (+44.88%) | 24.39 (106.62%) | |
client_sv2_mining_message_submit_standard_serialize | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 55.00 (+15.31%) | 53.72 (102.37%) | |
client_sv2_mining_message_submit_standard_serialize_deserialize | Instructions (instructions) | 🚨 (view plot | view alert) | 10,585.00 (+0.38%) | 10,573.43 (100.11%) | |
client_sv2_mining_message_submit_standard_serialize_deserialize | L1 Accesses (accesses) | 🚨 (view plot | view alert) | 15,400.00 (+0.37%) | 15,382.76 (100.11%) | |
client_sv2_open_channel_serialize_deserialize | Instructions (instructions) | 🚨 (view plot | view alert) | 8,027.00 (+0.51%) | 8,015.77 (100.14%) | |
client_sv2_open_channel_serialize_deserialize | L1 Accesses (accesses) | 🚨 (view plot | view alert) | 11,673.00 (+0.48%) | 11,657.12 (100.14%) | |
client_sv2_open_channel_serialize_deserialize | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 84.00 (+13.71%) | 83.67 (100.39%) | |
client_sv2_setup_connection | L2 Accesses (accesses) | 🚨 (view plot | view alert) | 15.00 (+59.70%) | 14.60 (102.73%) | |
client_sv2_setup_connection_serialize_deserialize | Instructions (instructions) | 🚨 (view plot | view alert) | 14,855.00 (+0.28%) | 14,843.28 (100.08%) | |
client_sv2_setup_connection_serialize_deserialize | L1 Accesses (accesses) | 🚨 (view plot | view alert) | 21,812.00 (+0.27%) | 21,794.51 (100.08%) |
Click to view all benchmark results
Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
client_sv2_handle_message_common | ✅ (view plot) | 2,077.00 (+1.28%) | 2,127.52 (97.63%) | ✅ (view plot) | 473.00 (+0.47%) | 486.21 (97.28%) | ✅ (view plot) | 732.00 (-0.02%) | 754.79 (96.98%) | ✅ (view plot) | 10.00 (+40.70%) | 11.10 (90.12%) | ✅ (view plot) | 37.00 (+0.93%) | 38.54 (96.01%) |
client_sv2_handle_message_mining | ✅ (view plot) | 8,219.00 (+0.26%) | 8,335.06 (98.61%) | ✅ (view plot) | 2,137.00 (+0.44%) | 2,171.05 (98.43%) | ✅ (view plot) | 3,159.00 (+0.44%) | 3,215.51 (98.24%) | ✅ (view plot) | 39.00 (+1.16%) | 43.53 (89.59%) | ✅ (view plot) | 139.00 (+0.10%) | 141.92 (97.94%) |
client_sv2_mining_message_submit_standard | ✅ (view plot) | 6,282.00 (+0.10%) | 6,386.58 (98.36%) | ✅ (view plot) | 1,750.00 (+0.03%) | 1,762.95 (99.27%) | ✅ (view plot) | 2,547.00 (-0.25%) | 2,575.41 (98.90%) | 🚨 (view plot | view alert) | 26.00 (+44.88%) | 24.39 (106.62%) | ✅ (view plot) | 103.00 (-0.76%) | 106.83 (96.41%) |
client_sv2_mining_message_submit_standard_serialize | ✅ (view plot) | 14,623.00 (-0.98%) | 15,031.15 (97.28%) | ✅ (view plot) | 4,694.00 (+0.01%) | 4,706.95 (99.72%) | ✅ (view plot) | 6,753.00 (-0.02%) | 6,774.84 (99.68%) | 🚨 (view plot | view alert) | 55.00 (+15.31%) | 53.72 (102.37%) | ✅ (view plot) | 217.00 (-2.31%) | 229.98 (94.36%) |
client_sv2_mining_message_submit_standard_serialize_deserialize | ✅ (view plot) | 27,435.00 (-0.15%) | 27,835.58 (98.56%) | 🚨 (view plot | view alert) | 10,585.00 (+0.38%) | 10,573.43 (100.11%) | 🚨 (view plot | view alert) | 15,400.00 (+0.37%) | 15,382.76 (100.11%) | ✅ (view plot) | 90.00 (+7.07%) | 90.32 (99.65%) | ✅ (view plot) | 331.00 (-1.08%) | 345.08 (95.92%) |
client_sv2_open_channel | ✅ (view plot) | 4,417.00 (-1.59%) | 4,609.89 (95.82%) | ✅ (view plot) | 1,461.00 (+0.05%) | 1,474.22 (99.10%) | ✅ (view plot) | 2,157.00 (+0.19%) | 2,172.87 (99.27%) | ✅ (view plot) | 11.00 (-7.78%) | 15.15 (72.58%) | ✅ (view plot) | 63.00 (-3.10%) | 68.16 (92.43%) |
client_sv2_open_channel_serialize | ✅ (view plot) | 14,006.00 (-1.41%) | 14,465.49 (96.82%) | ✅ (view plot) | 5,064.00 (+0.02%) | 5,077.22 (99.74%) | ✅ (view plot) | 7,321.00 (+0.04%) | 7,339.09 (99.75%) | ✅ (view plot) | 42.00 (+11.95%) | 42.67 (98.43%) | ✅ (view plot) | 185.00 (-3.37%) | 199.11 (92.91%) |
client_sv2_open_channel_serialize_deserialize | ✅ (view plot) | 22,523.00 (-0.49%) | 23,015.05 (97.86%) | 🚨 (view plot | view alert) | 8,027.00 (+0.51%) | 8,015.77 (100.14%) | 🚨 (view plot | view alert) | 11,673.00 (+0.48%) | 11,657.12 (100.14%) | 🚨 (view plot | view alert) | 84.00 (+13.71%) | 83.67 (100.39%) | ✅ (view plot) | 298.00 (-2.04%) | 314.92 (94.63%) |
client_sv2_setup_connection | ✅ (view plot) | 4,659.00 (-0.79%) | 4,764.06 (97.79%) | ✅ (view plot) | 1,502.00 (+0.05%) | 1,515.22 (99.13%) | ✅ (view plot) | 2,274.00 (-0.12%) | 2,299.19 (98.90%) | 🚨 (view plot | view alert) | 15.00 (+59.70%) | 14.60 (102.73%) | ✅ (view plot) | 66.00 (-2.63%) | 69.72 (94.66%) |
client_sv2_setup_connection_serialize | ✅ (view plot) | 15,942.00 (-1.88%) | 16,517.98 (96.51%) | ✅ (view plot) | 5,963.00 (+0.01%) | 5,976.22 (99.78%) | ✅ (view plot) | 8,662.00 (+0.08%) | 8,677.78 (99.82%) | ✅ (view plot) | 49.00 (+9.24%) | 49.58 (98.82%) | ✅ (view plot) | 201.00 (-4.52%) | 218.47 (92.00%) |
client_sv2_setup_connection_serialize_deserialize | ✅ (view plot) | 35,382.00 (-0.41%) | 35,747.47 (98.98%) | 🚨 (view plot | view alert) | 14,855.00 (+0.28%) | 14,843.28 (100.08%) | 🚨 (view plot | view alert) | 21,812.00 (+0.27%) | 21,794.51 (100.08%) | ✅ (view plot) | 110.00 (+9.80%) | 113.91 (96.57%) | ✅ (view plot) | 372.00 (-1.89%) | 385.27 (96.55%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
Report | Mon, July 22, 2024 at 18:52:27 UTC |
Project | Stratum v2 (SRI) |
Branch | 1047/merge |
Testbed | sv1 |
Click to view all benchmark results
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|
client-submit-serialize | ✅ (view plot) | 6,512.10 (-6.07%) | 7,409.55 (87.89%) |
client-submit-serialize-deserialize | ✅ (view plot) | 7,335.10 (-6.42%) | 8,338.46 (87.97%) |
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | ✅ (view plot) | 7,962.90 (-5.20%) | 8,843.62 (90.04%) |
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | ✅ (view plot) | 920.77 (+2.31%) | 929.59 (99.05%) |
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | ✅ (view plot) | 698.69 (+0.17%) | 718.43 (97.25%) |
client-sv1-authorize-serialize/client-sv1-authorize-serialize | ✅ (view plot) | 251.43 (+1.29%) | 255.19 (98.53%) |
client-sv1-get-authorize/client-sv1-get-authorize | ✅ (view plot) | 156.80 (-0.19%) | 162.27 (96.63%) |
client-sv1-get-submit | ✅ (view plot) | 6,305.70 (-5.88%) | 7,208.97 (87.47%) |
client-sv1-get-subscribe/client-sv1-get-subscribe | ✅ (view plot) | 282.15 (+1.24%) | 291.04 (96.95%) |
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | ✅ (view plot) | 775.68 (+3.54%) | 781.83 (99.21%) |
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | ✅ (view plot) | 619.58 (+0.74%) | 638.29 (97.07%) |
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | ✅ (view plot) | 203.07 (-1.67%) | 219.57 (92.48%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
|
Report | Mon, July 22, 2024 at 18:52:28 UTC |
Project | Stratum v2 (SRI) |
Branch | johnny/add-contrib |
Testbed | sv1 |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
---|---|---|---|---|---|
serialize_deserialize_handle_authorize | RAM Accesses (accesses) | 🚨 (view plot | view alert) | 368.00 (+1.09%) | 367.64 (100.10%) |
Click to view all benchmark results
Benchmark | Estimated Cycles | Estimated Cycles Results estimated cycles | (Δ%) | Estimated Cycles Upper Boundary estimated cycles | (%) | Instructions | Instructions Results instructions | (Δ%) | Instructions Upper Boundary instructions | (%) | L1 Accesses | L1 Accesses Results accesses | (Δ%) | L1 Accesses Upper Boundary accesses | (%) | L2 Accesses | L2 Accesses Results accesses | (Δ%) | L2 Accesses Upper Boundary accesses | (%) | RAM Accesses | RAM Accesses Results accesses | (Δ%) | RAM Accesses Upper Boundary accesses | (%) |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
get_authorize | ✅ (view plot) | 8,470.00 (+0.38%) | 8,722.70 (97.10%) | ✅ (view plot) | 3,746.00 (+0.14%) | 3,853.79 (97.20%) | ✅ (view plot) | 5,250.00 (+0.09%) | 5,399.37 (97.23%) | ✅ (view plot) | 7.00 (-11.53%) | 10.35 (67.64%) | ✅ (view plot) | 91.00 (+1.01%) | 94.05 (96.76%) |
get_submit | ✅ (view plot) | 95,441.00 (-0.12%) | 96,130.46 (99.28%) | ✅ (view plot) | 59,439.00 (-0.05%) | 59,773.05 (99.44%) | ✅ (view plot) | 85,361.00 (-0.05%) | 85,828.77 (99.45%) | ✅ (view plot) | 49.00 (-10.74%) | 62.60 (78.28%) | ✅ (view plot) | 281.00 (-0.38%) | 287.60 (97.71%) |
get_subscribe | ✅ (view plot) | 7,923.00 (-0.66%) | 8,265.00 (95.86%) | ✅ (view plot) | 2,841.00 (+0.38%) | 2,938.55 (96.68%) | ✅ (view plot) | 3,973.00 (+0.47%) | 4,098.10 (96.95%) | ✅ (view plot) | 13.00 (-19.10%) | 19.85 (65.51%) | ✅ (view plot) | 111.00 (-1.42%) | 116.85 (94.99%) |
serialize_authorize | ✅ (view plot) | 12,223.00 (+0.13%) | 12,499.95 (97.78%) | ✅ (view plot) | 5,317.00 (+0.10%) | 5,424.79 (98.01%) | ✅ (view plot) | 7,413.00 (+0.07%) | 7,562.71 (98.02%) | ✅ (view plot) | 10.00 (-7.17%) | 13.33 (75.05%) | ✅ (view plot) | 136.00 (+0.30%) | 140.20 (97.00%) |
serialize_deserialize_authorize | ✅ (view plot) | 24,520.00 (+0.19%) | 24,708.90 (99.24%) | ✅ (view plot) | 9,898.00 (-0.02%) | 10,024.26 (98.74%) | ✅ (view plot) | 13,960.00 (-0.05%) | 14,148.10 (98.67%) | ✅ (view plot) | 33.00 (-9.48%) | 41.59 (79.34%) | ✅ (view plot) | 297.00 (+0.69%) | 298.07 (99.64%) |
serialize_deserialize_handle_authorize | ✅ (view plot) | 30,301.00 (+0.49%) | 30,355.36 (99.82%) | ✅ (view plot) | 12,101.00 (+0.04%) | 12,208.79 (99.12%) | ✅ (view plot) | 17,116.00 (-0.01%) | 17,277.54 (99.07%) | ✅ (view plot) | 61.00 (+3.70%) | 64.67 (94.33%) | 🚨 (view plot | view alert) | 368.00 (+1.09%) | 367.64 (100.10%) |
serialize_deserialize_handle_submit | ✅ (view plot) | 126,406.00 (-0.00%) | 127,020.98 (99.52%) | ✅ (view plot) | 73,224.00 (-0.03%) | 73,613.89 (99.47%) | ✅ (view plot) | 104,946.00 (-0.04%) | 105,502.90 (99.47%) | ✅ (view plot) | 120.00 (-0.41%) | 131.10 (91.53%) | ✅ (view plot) | 596.00 (+0.19%) | 599.16 (99.47%) |
serialize_deserialize_handle_subscribe | ✅ (view plot) | 27,469.00 (+0.05%) | 27,599.29 (99.53%) | ✅ (view plot) | 9,643.00 (+0.11%) | 9,740.55 (99.00%) | ✅ (view plot) | 13,639.00 (+0.11%) | 13,773.91 (99.02%) | ✅ (view plot) | 64.00 (-2.67%) | 73.71 (86.82%) | ✅ (view plot) | 386.00 (+0.05%) | 388.51 (99.35%) |
serialize_deserialize_submit | ✅ (view plot) | 114,999.00 (-0.07%) | 115,642.56 (99.44%) | ✅ (view plot) | 68,001.00 (-0.08%) | 68,396.42 (99.42%) | ✅ (view plot) | 97,559.00 (-0.09%) | 98,141.34 (99.41%) | ✅ (view plot) | 65.00 (-6.18%) | 75.29 (86.33%) | ✅ (view plot) | 489.00 (+0.18%) | 492.35 (99.32%) |
serialize_deserialize_subscribe | ✅ (view plot) | 22,854.00 (-0.09%) | 23,107.56 (98.90%) | ✅ (view plot) | 8,195.00 (+0.11%) | 8,296.16 (98.78%) | ✅ (view plot) | 11,544.00 (+0.12%) | 11,681.05 (98.83%) | ✅ (view plot) | 36.00 (-8.35%) | 44.07 (81.69%) | ✅ (view plot) | 318.00 (-0.17%) | 321.45 (98.93%) |
serialize_submit | ✅ (view plot) | 99,758.00 (-0.13%) | 100,458.79 (99.30%) | ✅ (view plot) | 61,483.00 (-0.05%) | 61,822.35 (99.45%) | ✅ (view plot) | 88,208.00 (-0.05%) | 88,682.19 (99.47%) | ✅ (view plot) | 49.00 (-11.67%) | 62.44 (78.47%) | ✅ (view plot) | 323.00 (-0.50%) | 329.10 (98.15%) |
serialize_subscribe | ✅ (view plot) | 11,260.00 (-0.57%) | 11,601.03 (97.06%) | ✅ (view plot) | 4,188.00 (+0.26%) | 4,285.55 (97.72%) | ✅ (view plot) | 5,830.00 (+0.30%) | 5,957.24 (97.86%) | ✅ (view plot) | 15.00 (-8.06%) | 18.93 (79.23%) | ✅ (view plot) | 153.00 (-1.39%) | 159.68 (95.82%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
jbesraa
approved these changes
Jul 10, 2024
Shourya742
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6e95afe
@johnnyasantoss can you rebase and we will merge? |
6e95afe
to
31a146b
Compare
31a146b
to
511b72c
Compare
Rebased |
plebhash
approved these changes
Jul 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a link to the requirement on the doc about interoperability tests