TemplateProvider cleanup
#1369
Open
TemplateProvider cleanup
#1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbesraa
force-pushed
the
2025-01-21/template-provider-cleanup
branch
from
fa3fd22 to
94f2895
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
==========================================
+ Coverage 19.20% 19.51% +0.31%
==========================================
Files 166 155 -11
Lines 11107 10287 -820
==========================================
- Hits 2133 2008 -125
+ Misses 8974 8279 -695
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jbesraa
force-pushed
the
2025-01-21/template-provider-cleanup
branch
from
94f2895 to
c991b7f
Compare
jbesraa
commented
Jan 30, 2025
roles/tests-integration/lib/utils.rs
Outdated
| let response = minreq::get(download_url).send(); | ||
| match response { | ||
| Ok(res) => { | ||
| if res.status_code >= 200 && res.status_code < 300 { |
There was a problem hiding this comment.
previously we assumed only 200 is success.
jbesraa
force-pushed
the
2025-01-21/template-provider-cleanup
branch
from
c991b7f to
ee495f5
Compare
|
looks like clippy CI is breaking here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1368