Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sniffer fixes #1401

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Sniffer fixes #1401

merged 2 commits into from
Jan 30, 2025

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Jan 27, 2025

resolves #1384

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.20%. Comparing base (db38bf4) to head (b1cb0fc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1401   +/-   ##
=======================================
  Coverage   19.20%   19.20%           
=======================================
  Files         166      166           
  Lines       11107    11107           
=======================================
  Hits         2133     2133           
  Misses       8974     8974           
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.55% <ø> (ø)
binary_sv2-coverage 5.34% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.44% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.44% <ø> (ø)
pool_sv2-coverage 2.04% <ø> (ø)
protocols 24.74% <ø> (ø)
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 9.06% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbesraa jbesraa force-pushed the 2025-01-27/fix-sniffer branch 2 times, most recently from fb33466 to b95fafe Compare January 30, 2025 16:44
Previously we pushed the correct message but wrong message type after an
intercept. This is now fixed with using the message type from the
intercepet message directly.
+ make the function easier to read.
+ add test for intercepting `ToUpstream` direction.
@jbesraa jbesraa force-pushed the 2025-01-27/fix-sniffer branch from b95fafe to b1cb0fc Compare January 30, 2025 16:46
@plebhash plebhash merged commit 1d4b5c4 into stratum-mining:main Jan 30, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into Sniffer::recv_from_up_send_to_down as it seems broken
2 participants