cleanup async_std from network_helpers_sv2
#1433
Open
+31
−360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
==========================================
- Coverage 24.04% 18.90% -5.15%
==========================================
Files 112 157 +45
Lines 7942 11222 +3280
==========================================
+ Hits 1910 2121 +211
- Misses 6032 9101 +3069
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
plebhash
added a commit
to plebhash/stratum
that referenced
this pull request
Feb 1, 2025
as a consequence of stratum-mining#1433 and stratum-mining#1389
as a consequence of stratum-mining#1433 and stratum-mining#1389
plebhash
force-pushed
the
network_helpers_async_std_cleanup
branch
from
9588fc2 to
824f85d
Compare
Shourya742
suggested changes
Feb 2, 2025
| @@ -1,5 +1,5 @@ | |||
| [default] | |||
| features = "with_buffer_pool async_std tokio with_tokio default" | |||
| features = "with_buffer_pool tokio with_tokio default" | |||
There was a problem hiding this comment.
Suggested change
| features = "with_buffer_pool tokio with_tokio default" | |
| features = "with_buffer_pool default" |
| @@ -26,7 +26,7 @@ roles_logic_sv2 = { path = "../../../protocols/v2/roles-logic-sv2" } | |||
| const_sv2 = { path = "../../../protocols/v2/const-sv2" } | |||
| async-channel = "1.5.1" | |||
| binary_sv2 = { path = "../../../protocols/v2/binary-sv2/binary-sv2" } | |||
| network_helpers_sv2 = { path = "../../roles-utils/network-helpers", features=["tokio"] } | |||
| network_helpers_sv2 = { path = "../../roles-utils/network-helpers" } | |||
There was a problem hiding this comment.
any reason why we are not using ['use_buffer_pool'] feature here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1402
as described in #1402 (comment)