Bump windows-core to 0.56-0.59 range and regenerate with 0.59
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The required MSRV here is 1.62: https://docs.rs/crate/windows-core/0.56.0/source/Cargo.toml |
Kijewski
added
Tier-1
This includes the necessary binding changes for compatibility, provided by `windows-bindgen 0.53-0.54`. Generated code by `windows-bindgen` now also expects `TryInto` to be in scope via Rust's `prelude`, which is only the case in Rust edition `2021`.
The changes generated by `windows-bindgen 0.56` are not compatible with the previous `0.53-0.54` releases of `windows-core`.
MarijnS95
force-pushed
the
windows-0.56
branch
from
1c9e88c to
5b200bc
Compare
`windows-bindgen 0.59` now generates way less code since it no longer emits functions for which types are not enabled - that we don't use anyway! And the added bonus is that this generated code is compatible with `windows-core` all the way back to release `0.56`, meaning we don't force everyone to immediately upgrade once they're already on `0.56`.
MarijnS95
changed the title
windows-core to 0.56windows-core to 0.56-0.59 range and regenerate with 0.59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #131
windows-bindgen 0.59now generates way less code since it no longer emits functions for which types are not enabled - that we don't use anyway! And the added bonus is that this generated code is compatible withwindows-coreall the way back to release0.56, meaning we don't force everyone to immediately upgrade once they're already on0.56.