Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide invisible audio sources from the audio mixer #5144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hide invisible audio sources from the audio mixer #5144

wants to merge 1 commit into from
+32 −8

Conversation

holiber
Copy link
Contributor

@holiber holiber commented Sep 28, 2024

No description provided.

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 28, 2024

BundleMon

Files updated (1)
Status Path Size Limits
✅ renderer.(hash).js
 6.88MB (+704B +0.01%) -
Unchanged files (3)
Status Path Size Limits
✅ vendors~renderer.(hash).js
 4.7MB -
✅ updater.js
 115.28KB -
✅ guest-api.js
 40.19KB -

Total files change +704B +0.01%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@holiber
Copy link
Contributor Author

holiber commented Oct 3, 2024

Hmm. This PR breaks the test "Nested scenes should provide audio sources to mixer"
There should be another more complex algorithm for getting the list of visible sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@holiber