Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example to consume AVRO schema message produced by Java #300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zymap
Copy link
Member

@zymap zymap commented Oct 25, 2023


Motivation

Add an example to consume AVRO schema messages produced by Java producer.

---

### Motivation

Add an example to consume AVRO schema messages produced by Java producer.

(cherry picked from commit 4d19165)
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since we don't abstract schema internally, it can take a large effort to add full schema support >_<

It would be better you can add a doc (file or comment) to describe how to run this example.

@@ -54,6 +54,7 @@ tracing = { version = "^0.1.37", optional = true }
async-trait = "^0.1.72"
data-url = { version = "^0.3.0", optional = true }
uuid = { version = "^1.4.1", features = ["v4", "fast-rng"] }
apache-avro = "0.16.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to dev-dependencies as we don't support it in lib yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants