Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add eck olm-subscription #66

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat: Add eck olm-subscription #66

merged 2 commits into from
Oct 17, 2023

Conversation

ignacioli
Copy link
Contributor

  1. add elastic-cloud-eck olm-subscription;
  2. respect Subscription channel for all components.

@ignacioli
1. add elastic-cloud-eck olm-subscription;
9cf651d 
2. respect Subscription channel for all components.
@ignacioli ignacioli requested a review from a team as a code owner September 20, 2023 15:59
maxsxu
maxsxu requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure your PR title conform to conventional commit standard so we can better do release.

@ignacioli ignacioli changed the title add eck olm-subscription Add eck olm-subscription Sep 26, 2023
@ignacioli
Copy link
Contributor Author

@maxsxu you mean we follow by this doc https://github.com/marketplace/actions/conventional-commit-in-pull-requests?

@ignacioli ignacioli changed the title Add eck olm-subscription feat: Add eck olm-subscription Oct 17, 2023
@maxsxu maxsxu merged commit 0a5dfff into master Oct 17, 2023
1 check passed
@maxsxu maxsxu deleted the add-eck-olm-subscription branch October 17, 2023 07:21
@github-actions github-actions bot mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciiiii ciiiii ciiiii left review comments

@maxsxu maxsxu maxsxu approved these changes

Assignees

@maxsxu maxsxu

@ciiiii ciiiii

Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ignacioli @maxsxu @ciiiii